Cancel scheduled ControlConnection refresh if shutdown was called#440
Open
betalb wants to merge 1 commit intoapache:trunkfrom
Open
Cancel scheduled ControlConnection refresh if shutdown was called#440betalb wants to merge 1 commit intoapache:trunkfrom
betalb wants to merge 1 commit intoapache:trunkfrom
Conversation
Store timeout, used to schedule _refresh call, and clear it on shutdown. Even though _refresh call has check if shutdown was called, timeout itself may prevent nodejs process from shutting down until timeout reached.
Contributor
|
Is this the only refresh timeout that needs to be canceled? |
Author
|
Need to refresh my memory. There is one more suspicious timeout created in I have a code that handles this timeout as well, but need to write a test for this particular case. |
Author
|
Ah, no, there was another reason why I decided not to handle timeout in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store timeout, used to schedule refresh call, and clear it on shutdown.
Even though refresh call has check if shutdown was called, timeout itself may prevent nodejs process from shutting down until timeout is reached.
I have some concerns about test itself. Not sure that all the setup steps are required. But I've copied it mostly from previous test "should reconnect when all hosts go down and back up". What I wanted from the test:
So the main test is pasted below, the rest is a boilerplate copied from other test.