Cache DynamicDestinationsHelper.ConstantTimePartitioningClusteringDestination clustering & partitioning

[stankiewicz]

Fixes #36989
DynamicDestinationsHelper.ConstantTimePartitioningClusteringDestinations is parsing per element json configuration for partitioning and clustering which is expensive. Cache the outcome of evaluation so it's done once.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @stankiewicz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant performance enhancement to the BigQuery I/O connector by optimizing how partitioning and clustering configurations are handled. Previously, these configurations were parsed from JSON for every element, leading to unnecessary overhead. The change implements a caching strategy within ConstantTimePartitioningClusteringDestinations to ensure that these configurations are evaluated and stored only once, thereby reducing computational load and improving overall efficiency.

Highlights

• Performance Optimization: Implements caching for BigQuery partitioning and clustering configurations within DynamicDestinationsHelper.ConstantTimePartitioningClusteringDestinations.
• Reduced JSON Parsing: Prevents redundant and expensive per-element JSON parsing of partitioning and clustering configurations.
• Lazy Initialization: Introduces a lazy, synchronized initialization mechanism to evaluate and cache these configurations only once.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[stankiewicz]

/gemini review

[gemini-code-assist]

Code Review

The pull request aims to improve performance by caching the evaluation of partitioning and clustering configurations within ConstantTimePartitioningClusteringDestinations. This is a valuable optimization. However, a critical issue exists with the serialization of the initialized flag, which could lead to incorrect behavior and negate the caching benefits in a distributed environment.

[stankiewicz]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces caching for partitioning and clustering configurations to avoid expensive repeated JSON parsing, which is a good performance improvement. The implementation uses double-checked locking with an AtomicBoolean for lazy initialization. My feedback includes a suggestion to make the initialized flag final for improved thread-safety and another to refactor duplicated logic for better maintainability.

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[github-actions]

Assigning reviewers:

R: @chamikaramj for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[github-actions]

Reminder, please take a look at this pr: @chamikaramj