-
Notifications
You must be signed in to change notification settings - Fork 16
Implement Jupyter integration #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There is another point to discuss before I can implement it: how many rows and columns to display.
I'm not sure which one is preferable. |
|
I also failed to run |
|
Here is an example of this integration (can preview on GitHub): https://gist.github.com/xubaiwang/d56db9d84c671dbaa75901813941bd3b |
|
Thanks for the pull request. I think we should not have this function live on the table (if possible) since it cannot be treeshaken. Is there a way to have it outside so we can tree shake the code when it's not needed? |
|
@domoritz I think it's currently impossible. Although it can be moved to a separate function, this is far less useful in Jupyter context. People do not want an extra function to inspect a single value. Is it possible to create a Deno specific target/platform (called If we make this feature deno/jupyter platform specific (through prototype mutation and .d.ts |
|
Maybe it's small enough to be okay. Should columns also be supported? And for perf, does += perform similar to building an array and then joining it into a string? |
This is why this is still a draft, there are many things left to implement and optimize.
Do you mean something like
However, the final implementation may be non trivial. There are other things like date formatting, json schema creation (for vnd.dataresource+json MIME type), formatting options, etc. |
|
I see. So maybe it does make sense to have a separate deno build then. |
What's Changed
This pull request implements Jupyter integration for arrow-js, including the following two mime type:
text/htmlapplication/vnd.dataresource+jsonThis implementation basically follows
nodejs-polars's implementation.Closes #245.