fix: implement LRU cache for session memory management #1493
+1,296
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a comprehensive solution for the memory leak issue in session management by introducing an LRU (Least Recently Used) cache system with configurable limits and TTL-based expiration.
Problem
The original session management system had several memory leak issues:
Mapobjects that grew indefinitelySolution
Core Implementation
Configuration Options
New configuration section in
opencode.json:{ "memory": { "maxSessions": 100, "maxMessagesPerSession": 1000, "sessionTtlMs": 86400000, "inactiveTtlMs": 14400000, "cleanupIntervalMs": 300000 } }Changes
packages/opencode/src/session/memory-manager.ts: New LRU cache implementationpackages/opencode/src/session/index.ts: Integrated memory management (backward compatible)packages/opencode/src/config/config.ts: Added memory configuration schemapackages/opencode/test/session/: Comprehensive test suite (40+ test cases)Testing
Performance Impact
Breaking Changes
None. This is a drop-in replacement that maintains full API compatibility.
Fixes memory leak in long-running sessions by preventing unbounded growth of session and message data in memory.