This repository was archived by the owner on Nov 27, 2025. It is now read-only.
Update package.json to have Karma v0.12#130
Closed
binarydev wants to merge 14 commits intoangular:masterfrom
Closed
Update package.json to have Karma v0.12#130binarydev wants to merge 14 commits intoangular:masterfrom
binarydev wants to merge 14 commits intoangular:masterfrom
Conversation
- add ngApp directive to bootstrap the app - add simple template with an expression
- Added static html list with two phones into index.html
- Converted the static html list into dynamic one by:
- creating PhoneListCtrl controller for the application
- extracting the data from HTML into a the controller as an in-memory
dataset
- converting the static document into a template with the use of
`[ngRepeat]` [directive] which iterates over the dataset with phones,
clones the ngRepeat template for each instance and renders it into the
view
- Added a simple unit test to show off how to write tests and run them
with JsTD (see README.md for instructions)
- Added a search box to demonstrate how: - the data-binding works on input fields - to use [filter] filter - [ngRepeat] automatically shrinks and grows the number of phones in the view - Added an end-to-end test to: - show how end-to-end tests are written and used - to prove that the search box and the repeater are correctly wired together
- Add "age" property to the phone model - Add select box to control phone list order - Override the default order value in controller - Add unit and e2e test for this feature
- Replaced the in-memory dataset with data loaded from the server (in the form of static phone.json file to make this tutorial backend agnostic) - The json file is loaded using the [$http] service - Demonstrate the use of [services][service] and [dependency injection][DI] - The [$http] is injected into the controller through [dependency injection][DI]
- adding phone image and links to phone pages - add end2end test that verifies our phone links - css to style the page just a notch
- Introduce the [$route] service which allows binding URLs for deep-linking with
views
- Create PhoneCatCtrl which governs the entire app and contains $route
configuration
- Load the ngRoute module
- Map `/phones' to PhoneListCtrl and partails/phones-list.html
- Map `/phones/<phone-id>' to PhoneDetailCtrl and partails/phones-detail.html
- Copy deep linking parameters to root controller `params` property for access
in sub controllers
- Replace content of index.html with [ngView] directive
- Create phone list route
- Preserve existing PhoneListCtrl controller
- Move existing html from index.html to partials/phone-list.html
- Create phone details route
- Empty placeholder PhoneDetailsCtrl controller
- Empty placeholder partials/phane-details.html template
- Fetch data for and render phone detail view
- PhoneDetailCtrl controller to fetch details json with [$xhr] for a specific
phone
- template for the phone detailed view
- CSS to make the phone details page look "pretty"
- Added custom checkmark filter - Update phone detail template to use checkmark filter - Added spec for the filter
In the phone detail view, clicking on a thumbnail image, changes the main phone image to be the large version of the thumbnail image. - Define mainImageUrl model variable in the PhoneDetailCtrl and set its default value - Create setImage controller method to change mainImageUrl - Register ng:click handler for thumb images to use setImage controller method - Add e2e tests for this feature - Add css to change the mouse cursor when user points at thumnail images
- Replaced [$xhr] with [$resource] - Created a custom Phone service that represents the $resource client
This fixes the error that is currently being presented when attempting to follow the initial setup for the AngularJS tutorial. Error shown is as follows: npm ERR! peerinvalid The package karma-requirejs does not satisfy its siblings' peerDependencies requirements! npm ERR! peerinvalid Peer karma@0.10.10 wants karma-requirejs@~0.2.0 npm ERR! System Darwin 13.1.0 npm ERR! command "node" "/usr/local/bin/npm" "install" npm ERR! cwd /Users/jsantiago/Sites/angular-phonecat npm ERR! node -v v0.10.26 npm ERR! npm -v 1.4.3 npm ERR! code EPEERINVALID
|
Other PR merged #129. |
|
It turns out to be kind of hard work to land these patches, I want to make sure I didn't break anything before merging this one. I tested it out locally and npm install failed before the patch was applied, but succeeded after, so I don't think there's any pressure to land this right away |
Contributor
|
Updating the peer dependency solved this problem in #129 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the error that is currently being presented when attempting to follow the initial setup for the AngularJS tutorial. Error shown is as follows:
npm ERR! peerinvalid The package karma-requirejs does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer karma@0.10.10 wants karma-requirejs@~0.2.0
npm ERR! System Darwin 13.1.0
npm ERR! command "node" "/usr/local/bin/npm" "install"
npm ERR! cwd /Users/jsantiago/Sites/angular-phonecat
npm ERR! node -v v0.10.26
npm ERR! npm -v 1.4.3
npm ERR! code EPEERINVALID