Skip to content

Conversation

@dashkan
Copy link

@dashkan dashkan commented Aug 18, 2017

Allows targeting electron renderer using the new platform property in .angular-cli.json.

Happy to add wiki story for the use case.

This resolves issue #5767

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@dashkan
Copy link
Author

dashkan commented Aug 18, 2017

@hansl, I created a new PR. Same CLA block error. My GH primary email is the same as my google account w/ signed CLA. Thoughts?

@devoto13
Copy link
Contributor

@ashkandaie That's because in your commits you use different email address. See:

$ git log
commit c9a818655274cbe75b86ec76db2f098e28c9213e (HEAD -> master, origin/support-platform-electron-renderer, origin/master, origin/HEAD)
Merge: db4c9351 e746369c
Author: Ashkan Daie <ashkan@ashkan-mbp.lan>

You'll need to set it to the email you signed CLA with and re-create/edit your commits. See here how to do it. Also check commit message guidelines. You'll need to fix it as well for build to pass.

@markfknight
Copy link

markfknight commented Aug 19, 2017

@ashkandaie This is an awesome addition thanks.

Quick question, does 'ng serve' need to be blocked, I currently use and ejected webpack config with "target": "electron-renderer" and serve to localhost:4200 via 'webpack-dev-server' with no issues, would be good to retain this functionality if possible.

@filipesilva
Copy link
Contributor

I appreciate the time you took to make a PR for this, but we aren't ready yet to add new platforms and support them. We're tentatively adding platform-server as experimental but will need more time to properly design and add more platform support. So for now I will close this PR.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants