Skip to content

chore: remove Open WebUI component#818

Merged
Gkrumbach07 merged 1 commit intomainfrom
remove-open-webui
Mar 5, 2026
Merged

chore: remove Open WebUI component#818
Gkrumbach07 merged 1 commit intomainfrom
remove-open-webui

Conversation

@jeremyeder
Copy link
Contributor

Summary

  • Removes the entire components/open-webui-llm/ directory
  • Deletes 20 files (~1,500 lines)
  • No other parts of the codebase referenced this component

Removed

  • Kubernetes manifests (deployments, services, PVCs, RBAC)
  • Kustomize overlays for Kind cluster
  • Documentation (PHASE1.md, PHASE2.md)
  • Makefile and README

🤖 Generated with Claude Code

The Open WebUI + LiteLLM integration is no longer needed. This removes
the entire open-webui-llm component including:
- Kubernetes manifests (deployments, services, PVCs, RBAC)
- Kustomize overlays for Kind cluster
- Documentation (PHASE1.md, PHASE2.md)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Claude Code Review

Summary

PR #818 removes the entire components/open-webui-llm/ directory — a standalone Open WebUI + LiteLLM deployment component — deleting 20 files and approximately 1,500 lines. This is a clean housekeeping change; the component was self-contained and no references to it remain anywhere in the codebase. The validate-manifests CI check passes. Overall this is a straightforward and safe deletion.

Issues by Severity

Blocker Issues

None

Critical Issues

None

Major Issues

None

Minor Issues

  1. overlays/phase1-kind/secrets.yaml was tracked in gitcomponents/open-webui-llm/overlays/phase1-kind/secrets.yaml (now deleted) was a committed Kubernetes Secret manifest that included a hardcoded LITELLM_MASTER_KEY: "sk-litellm-dev-master-key". Even for a dev-only component, tracking any Secret manifest in git risks accidental real-credential substitution going unnoticed. The .env.example pattern already present in this component is the right approach. This PR eliminates the issue by deleting the file; noting it for awareness on future components.
    (Violates security-standards.md: "No secrets in code")

Positive Highlights

  • Zero dangling references: A thorough search confirms no other files reference open-webui-llm, openwebui, or litellm anywhere in the repository. The removal is complete and clean.
  • Accurate PR description: The summary clearly enumerates what was removed and confirms no cross-component dependencies existed.
  • Conventional commit format: chore: remove Open WebUI component correctly categorises a cleanup-only change.
  • CI passes: validate-manifests succeeds, confirming the removal does not break any referenced Kustomize bases or overlays.
  • Correct use of .env.example: The component previously included .env.example (not .env) for documenting required secrets — the right pattern for anything tracked in git.

Recommendations

  1. (Minor, informational) For any future component that manages Kubernetes Secret manifests for development use, prefer generating secrets at deploy time (e.g., via a make target or kubectl create secret) rather than committing even templated Secret YAML to the repository. The .env.example + runtime generation pattern is the safer default.

🔍 View AI decision process (logs available for 90 days)

📋 View memory system files loaded (click to expand)

What Amber Loaded for Code Review

Amber automatically loaded these repository standards from the memory system:

  1. CLAUDE.md - Master project instructions, development standards
  2. backend-development.md - Go backend, K8s integration patterns
  3. frontend-development.md - NextJS, Shadcn UI, React Query patterns
  4. security-standards.md - Auth, RBAC, token handling
  5. k8s-client-usage.md - User token vs service account patterns
  6. error-handling.md - Consistent error patterns
  7. react-query-usage.md - Data fetching patterns

Impact: This review used your repository's specific code quality standards, security patterns, and best practices from the memory system (PRs #359, #360) - not just generic code review guidelines.

@ambient-code ambient-code bot added this to the Merge Queue milestone Mar 5, 2026
@Gkrumbach07 Gkrumbach07 merged commit 4981f6a into main Mar 5, 2026
5 checks passed
@Gkrumbach07 Gkrumbach07 deleted the remove-open-webui branch March 5, 2026 17:22
@ambient-code ambient-code bot removed this from the Merge Queue milestone Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants