Skip to content

RHOAIENG-51600: Document where to find Vertex AI service account key#782

Merged
Gkrumbach07 merged 1 commit intomainfrom
kdreyer/vertex-key-docs
Mar 5, 2026
Merged

RHOAIENG-51600: Document where to find Vertex AI service account key#782
Gkrumbach07 merged 1 commit intomainfrom
kdreyer/vertex-key-docs

Conversation

@ktdreyer
Copy link
Contributor

@ktdreyer ktdreyer commented Mar 3, 2026

Summary

  • Add a note to the kind local development docs pointing developers to the service account key in Bitwarden
  • Previously there was no documentation for where to obtain this file — it was passed along as tribal knowledge

Fixes https://issues.redhat.com/browse/RHOAIENG-51600

Developers had no written instructions for obtaining the
service account JSON key for local Vertex AI development.
The key is now in the team's Bitwarden collection.

RHOAIENG-51600
@ktdreyer ktdreyer changed the title Document where to find Vertex AI service account key RHOAIENG-51600: Document where to find Vertex AI service account key Mar 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

Claude Code Review

Summary

This PR adds a 4-line documentation note to the Kind local-development guide, pointing developers to the Vertex AI service account key stored in Bitwarden. The change converts tribal knowledge into documented guidance and carries no code risk.

Issues by Severity

Blocker Issues

None

Critical Issues

None

Major Issues

None

Minor Issues

docs/internal/developer/local-development/kind.md — Hard-coded Bitwarden collection name

The note hard-codes both the collection name ("Ambient Code Support") and the expected filename (ambient-code-key.json). This is fine for a fully-private repo, but worth noting:

  • If the repo is ever made public (or partially mirrored), the organisational Bitwarden structure becomes visible.
  • If the collection or file is renamed in Bitwarden, the docs silently go stale with no way to detect the drift.

Not a blocker — internal developer docs routinely reference credential stores — but something to keep in mind as the project matures. Consider adding a fallback hint such as: (search for "Vertex" or "ambient-code" if the path above is stale).

Positive Highlights

  • Excellent call converting tribal knowledge into written documentation. New team members no longer need to track down the right person to obtain the credential file.
  • The placement is exactly right: immediately adjacent to the LOCAL_VERTEX=true flag and the default credential path, making it easy to discover.
  • The internal docs path (docs/internal/developer/...) is correct — no risk of this guidance surfacing to end users.

Recommendations

  1. (Optional) Add a short fallback hint for finding the credential in case the Bitwarden collection is renamed.
  2. No code changes required — safe to merge as-is.

🔍 View AI decision process (logs available for 90 days)

📋 View memory system files loaded (click to expand)

What Amber Loaded for Code Review

Amber automatically loaded these repository standards from the memory system:

  1. CLAUDE.md - Master project instructions, development standards
  2. backend-development.md - Go backend, K8s integration patterns
  3. frontend-development.md - NextJS, Shadcn UI, React Query patterns
  4. security-standards.md - Auth, RBAC, token handling
  5. k8s-client-usage.md - User token vs service account patterns
  6. error-handling.md - Consistent error patterns
  7. react-query-usage.md - Data fetching patterns

Impact: This review used your repository's specific code quality standards, security patterns, and best practices from the memory system (PRs #359, #360) - not just generic code review guidelines.

@ambient-code ambient-code bot added this to the Merge Queue milestone Mar 3, 2026
@Gkrumbach07 Gkrumbach07 merged commit b486556 into main Mar 5, 2026
6 checks passed
@Gkrumbach07 Gkrumbach07 deleted the kdreyer/vertex-key-docs branch March 5, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants