docs: Add React state stability patterns and theme creation guidelines#758
Open
ambient-code[bot] wants to merge 1 commit intomainfrom
Open
docs: Add React state stability patterns and theme creation guidelines#758ambient-code[bot] wants to merge 1 commit intomainfrom
ambient-code[bot] wants to merge 1 commit intomainfrom
Conversation
Based on user feedback from sessions session-1772352044 and session-1772054943. **Improvements:** 1. **New Pattern: React State Stability** (.claude/patterns/react-state-stability.md) - Addresses common React rendering anti-pattern: recalculating time-sensitive values on each render - Provides debugging checklist for timestamp-related bugs - Prevents misdiagnosis of rendering issues as data issues - Includes examples of stable value patterns and memoization 2. **Theme Creation Guidelines** (.claude/context/frontend-development.md) - Ensures new theme variants are visually distinct from existing themes - Defines minimum contrast requirements (20% lightness difference) - Provides visual distinction checklist and examples - Prevents creation of nearly-identical theme variants **Context:** - Correction 1: Agent created LibreChat theme too similar to light theme - Correction 2: Agent misdiagnosed timestamp bug as data issue when it was a rendering issue Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
maskarb
approved these changes
Mar 5, 2026
mprpic
approved these changes
Mar 5, 2026
Contributor
|
We should hold on this one and talk about it as a team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds targeted documentation improvements based on 2 user corrections from feedback loop analysis:
Changes
New Pattern File: React State Stability
.claude/patterns/react-state-stability.mdnew Date()was called on every render, causing timestamps to update to current timeUpdated: Theme Creation Guidelines
.claude/context/frontend-development.mdSession
Improvement Session: Project
ambient-platform-and-workflow-feedback-loop-running/ Sessionsession-1772443051Correction Summary
Testing
🤖 Generated via feedback loop analysis in session
session-1772443051