fix(leaderboard): use upstream schema for fork PR validation#335
Open
kami619 wants to merge 1 commit intoambient-code:mainfrom
Open
fix(leaderboard): use upstream schema for fork PR validation#335kami619 wants to merge 1 commit intoambient-code:mainfrom
kami619 wants to merge 1 commit intoambient-code:mainfrom
Conversation
When a user submits a leaderboard entry from a fork that hasn't been synced with upstream, the workflow was using the fork's outdated schema for validation. This caused valid submissions to fail with errors like "attributes_total: 25 was expected" even though PR ambient-code#312 had already fixed the schema to allow 10-25 attributes. This fix changes the workflow to: 1. Checkout upstream main for validation tools and schema 2. Fetch only the submission file from the PR branch 3. Validate using upstream's agentready installation This ensures validation always uses the latest schema while still validating the actual submitted file from the PR. Fixes the validation failure on PR ambient-code#332. See: ambient-code#312 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
📈 Test Coverage Report
Coverage calculated from unit tests only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user submits a leaderboard entry from a fork that hasn't been synced with upstream, the workflow was using the fork's outdated schema for validation. This caused valid submissions to fail with errors like "attributes_total: 25 was expected" even though PR #312 had already fixed the schema to allow 10-25 attributes.
This fix changes the workflow to:
This ensures validation always uses the latest schema while still validating the actual submitted file from the PR.
Fixes the validation failure on PR #332.
See: #312