functions: gdrivedl handle file id with grep instead sed #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduces the regex complexity + removes the limitation that if url contains string folder than separate regex is used for it Signed-off-by: Yuvraj Saxena <infectedx27@gmail.com>
msfjarvis
reviewed
Jan 22, 2019
Collaborator
msfjarvis
left a comment
msfjarvis
left a comment
There was a problem hiding this comment.
I'd rather keep lengthy sed I understand over shorter grep I don't.
Author
My one isn't complex as yours and is also follows Google sheet API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.