Conversation
…ds to be removed and more style to the resume
…ered. Removed title left-margin in mobile view
GannonDetroit
left a comment
GannonDetroit
left a comment
There was a problem hiding this comment.
Your project looks great on the screen. Your code is well written and very organized. You nailed the MVP and hit the stretch. Just go back and add the missing meta tag and you're good to go.
I look forward to see what you add to this as you continue to go through your training at Lambda.
|
|
||
| <title>My Resume</title> | ||
|
|
||
| <link href="https://fonts.googleapis.com/css?family=Noto+Serif" rel="stylesheet"> |
There was a problem hiding this comment.
good job bringing in the google fonts, but it looks like you're missing a certain meta tag that should be around this area. Let me know when you add it in.
| </header> | ||
| <main> | ||
|
|
||
| <!-- Summary of Skills --> |
There was a problem hiding this comment.
great job with adding the white space and comments in the code.
| b, u, i, center, | ||
| dl, dt, dd, ol, ul, li, | ||
| fieldset, form, label, legend, | ||
| table, caption, tbody, tfoot, thead, tr, th, td, |
There was a problem hiding this comment.
What happened here?
Did you delete and have to re-add the reset?
|
|
||
| html, body { | ||
| height: 100%; | ||
| @secondary: #1b0e3a; //dark black --> purple |
There was a problem hiding this comment.
good job using variables. I like that you actually used hex codes and not just "black" or "blue". You even added a comment like in line 158 to explain what the hex color code should roughly look like. Great job
| @accent: #fffbaa; // light yellow | ||
|
|
||
| // Mixins | ||
| .flexAlign(@justify, @align) { |
There was a problem hiding this comment.
good job on the mixins, you've demonstrated you understand how and why to use them. These look like quality Mixin's as well.
Good job.
2 participants
Made an effort to get some more comments in.
Code should meet all MVP and stretch requirements. Layout still looks off, though. Will continue to work on it.
Also have it hosted at https://ajbrush.com/resume/index.html