init push #5
Open
init push #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wc0sby
reviewed
Aug 7, 2018
wc0sby
left a comment
wc0sby
left a comment
There was a problem hiding this comment.
Nice work. Try to refactor a bit and rethink the assignment scope of 'doesItContainVowel'
|
|
||
| //global variables | ||
| const theVowels = ['a', 'e', 'i', 'o', 'u']; | ||
| let doesItContainVowel=false; |
There was a problem hiding this comment.
Keeping this in the global scope is dangerous as it can be overwritten. Think of another way to write your code so that this accessible only when needed.
| // to not be outside of this range, if not in range return false | ||
| const isValid = (word) => { | ||
| for(const letter of word){ | ||
| if(letter <'a' || letter >'z'){ |
There was a problem hiding this comment.
Refactor this and test the true first. If you return true first, the false is implicit. Also, you could shorten even further. Really neat trick here, btw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3