Checkpoint2 #12
Open
Checkpoint2 #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wc0sby
reviewed
Sep 11, 2018
| the weather array. map() function finds the weather_state_names, new Set assigns the | ||
| weather_state_names using the spread operator to weatherStates. | ||
| */ | ||
| const weatherStates = [...new Set(weather.map(names => names.weather_state_name))]; |
There was a problem hiding this comment.
Nice find, but careful with browser compatibility
| /*find the id of the object in weather that has a min_temp of 15.915. filter() returns | ||
| new array with elements that pass test. map() returns only the id property from that object. | ||
| */ | ||
| const idealTemp = weather.filter(function(item, index, arr) { |
There was a problem hiding this comment.
This should return the id, not an array with the id. Think of another higher order method that would return the item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3