Skip to content

Conversation

@Loufe
Copy link

@Loufe Loufe commented Apr 9, 2023

Following @abetlen's great work on #40 I did some testing and was able to modify Ooba's one-click install to use it. Works great on my branch.

Admittedly /wheels/ directory is a bit of a crude way of dealing with this, I'm sure there's way to bundle them only into the release section so there are no binaries floating around in the code.

SHA256 of .whl: FEAAF0D4002018A15992B12CF57319CDCBAC27DE0C78CF86EB16EC6A58BD86A7

@abetlen
Copy link
Owner

abetlen commented Apr 10, 2023

hey @Loufe can you check the release wheels to make sure I've added the correct ones, sorry there's so many, I went with the approach here https://github.com/pypa/cibuildwheel

@Loufe
Copy link
Author

Loufe commented Apr 10, 2023

@abetlen tested and working, LGTM! Good choice with Cibuildwheel.

I might suggest that until such a time as someone requests a wheel for another OS / Windows arch / Python version, we save Github some electricity and leave the release cleaner by limiting the build to specific wheels. According to Pypa there is a param to limit version "CIBW_BUILD", i.e.:
CIBW_BUILD: cp310-*

That said, I would even go so far as to limit the build to amd64:
CIBW_BUILD: cp310-win_amd64

By the way, I was wondering how to account for changing versions in Ooba's one-click installer batch. I wrote this call to adjust for current tag name - does this look ok to you? I guess more specifically, you don't plan on changing build formats at any points?

for /f "usebackq delims=" %%i in (`powershell -command "$url = 'https://api.github.com/repos/abetlen/llama-cpp-python/releases/latest'; $response = Invoke-RestMethod -Uri $url; $response.tag_name"`) do set TAG_NAME=%%i
call python -m pip install https://github.com/abetlen/llama-cpp-python/releases/download/%TAG_NAME%/llama_cpp_python-%TAG_NAME:~1%-cp310-cp310-win_amd64.whl

@Loufe
Copy link
Author

Loufe commented Apr 10, 2023

Tested CIBW_Build: cp310-* in a35a233, works as it should.

In any case you should close this PR (too many commits to undo gitignore change and wheels dir, etc.)
If you agree with limiting to 3.10, you should be able to integrate the .yaml modifications on your end from that commit easily.

@abetlen
Copy link
Owner

abetlen commented Apr 10, 2023

@Loufe thanks! I'll leave the other wheels in case anyone needs them but I'll investigate which ones are completely redundent in the future.

@abetlen abetlen closed this Apr 10, 2023
@gjmulder gjmulder added the windows A Windoze-specific issue label May 18, 2023
@gjmulder gjmulder added the oobabooga https://github.com/oobabooga/text-generation-webui label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oobabooga https://github.com/oobabooga/text-generation-webui windows A Windoze-specific issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants