Configurable CPU rendering on per engine basis#9
Merged
dkyurtov merged 2 commits intorelease/3.29.0from Apr 29, 2025
Merged
Conversation
- Added the ability to enable cpu rendering for each FlutterDartProject rather than globally. - Created ci.yml and release.yml
dkyurtov
force-pushed
the
feature/configurable-cpu-rendering
branch
10 times, most recently
from
3b72127 to
b99ec6d
Compare
dkyurtov
force-pushed
the
feature/configurable-cpu-rendering
branch
from
b99ec6d to
2139e86
Compare
valentinvarbanov
approved these changes
Apr 22, 2025
| // Makes sure we have an existing pointer | ||
| auto iter = states_.find(pointer_data.device); | ||
| FML_DCHECK(iter != states_.end()); | ||
| // FML_DCHECK(iter != states_.end()); |
Author
There was a problem hiding this comment.
Yes, this assert crashing when you move the application to background.
| // nullptr // release callback | ||
| // )); | ||
|
|
||
| // copy data, TODO: optimize to avoid repeated alloc/dealloc |
Member
There was a problem hiding this comment.
I will suggest to create a followup task for the TODO.
rumen-cholakov
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.