Open
Conversation
This PR fixes all of the Cupertino cross imports, except for the one that uses `SelectableText`, which needs further discussion. Some Material specific tests for Cupertino are now under `tests/material/cupertino`. Part of flutter#177415 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
…tter#182141) Replace `MaterialApp` with `TestWidgetsApp` and `Colors.blue`/`Colors.red` with named constants to remove the Material library dependency. Part of flutter#177414 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
This PR moves: * TestTextField from editable_text_utils.dart to editable_text_tester.dart * TestListTile from list_tile_test_utils.dart to list_tile_tester.dart * TestButton from utils.dart to button_tester.dart The purpose is to align with other Test* widgets, such as TestWidgetsApp in [widgets_app_tester.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/widgets_app_tester.dart) and TestSemantics in [semantics_tester.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/semantics_tester.dart).
fixes flutter#181399 I'm unable to verify 100% that this is the failure since i can't reproduce it locally but I believe this is it. test exempt: is a test ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
…utility function. (flutter#182196) This resolves flutter#180949 This is follow-up on flutter#180098
Surprised we missed this when reviewing the 0x0 PRs. cc @ahmedsameha1
…lutter#182404) <!-- start_original_pr_link --> Reverts: flutter#181634 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: chunhtai <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: tree breakage <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: navaronbracke <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {justinmc} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: This PR fixes all of the Cupertino cross imports, except for the one that uses `SelectableText`, which needs further discussion. Some Material specific tests for Cupertino are now under `tests/material/cupertino`. Part of flutter#177415 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
…#182395)" (flutter#182406) <!-- start_original_pr_link --> Reverts: flutter#182395 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: gaaclarke <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: this is causing breakages on the dashboard example: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8689933991528003217/+/u/run_test.dart_for_framework_tests_shard_and_subshard_libraries/stdout ``` 10:36 +9458 ~24: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/dialog_test.dart: Dialog children padding is correct AlertDialog padding is correct when only icon, title a <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: justinmc <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {Renzo-Olivares, victorsanni, navaronbracke} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: This PR moves: * TestTextField from editable_text_utils.dart to editable_text_tester.dart * TestListTile from list_tile_test_utils.dart to list_tile_tester.dart * TestButton from utils.dart to button_tester.dart The purpose is to align with other Test* widgets, such as TestWidgetsApp in [widgets_app_tester.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/widgets_app_tester.dart) and TestSemantics in [semantics_tester.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/semantics_tester.dart). We should continue to follow this pattern in the future, such as in flutter#181722. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
…flutter#182384) fixes flutter#180764 test exempt: is test Opengles requires a separate context for the raster and io threads that have a share group. Swangle doesn't seem to have support for that so we'll just run the opengles tests in a single threaded environment. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
…2401) https://skia.googlesource.com/skia.git/+log/bb69b5b71b4f..7dc3ba9b1d90 2026-02-13 mike@reedtribe.org Removing obsolete math benches 2026-02-13 borenet@google.com [infra] Update iOS provisioning profile, add create script If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC bungeman@google.com,jimgraham@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fix flutter#161592 The current implementation does not fully reflect [letter-spacing](https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/letter-spacing), [word-spacing](https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/word-spacing), and [line-height](https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/line-height) in the DOM. 0bc99f8 And the current implementation generates an DomHTMLTextAreaElement every time the `enabled`. Therefore, it reapplies the [scrollTop](https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollTop) value that the Element had been holding internally. 7264912 https://github.com/user-attachments/assets/6f575366-12a0-4246-b2ab-eb2a0e85cfa5 https://github.com/user-attachments/assets/ec660d4c-5166-450c-be38-77b90fcfce76 ```dart import 'package:flutter/material.dart'; void main() => runApp(const MainApp()); class MainApp extends StatelessWidget { const MainApp({super.key}); @OverRide Widget build(BuildContext context) { return const MaterialApp(home: MainPage()); } } class MainPage extends StatelessWidget { const MainPage({super.key}); @OverRide Widget build(BuildContext context) { return Scaffold( appBar: AppBar(title: Text('Selection position')), body: SingleChildScrollView( padding: const .all(16), child: Column( children: [ const Text('height=null'), TextField(maxLines: 5, style: TextStyle(height: null)), const Text('height=1.0'), TextField(maxLines: 5, style: TextStyle(height: 1.0)), const Text('height=2.0'), TextField(maxLines: 5, style: TextStyle(height: 2.0)), ], ), ), ); } } ``` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
) https://skia.googlesource.com/skia.git/+log/7dc3ba9b1d90..befeec673f1b 2026-02-13 fmalita@google.com [skottie] Add Viewer keybind for CoreText-based shaping If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC bungeman@google.com,jimgraham@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/befeec673f1b..e5a18f8f0d4a 2026-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 92cf0901ef59 to 6a86f2fce200 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC bungeman@google.com,jimgraham@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#182414) https://dart.googlesource.com/sdk.git/+log/7a2a28dbd0d4..f82ec89435f5 2026-02-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-149.0.dev 2026-02-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-148.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/e5a18f8f0d4a..91d158b0a61e 2026-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 1f4a9ec2512b to 48f5ceeea3ef (13 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC bungeman@google.com,jimgraham@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…... (flutter#182423) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter Please CC jimgraham@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…2424) https://skia.googlesource.com/skia.git/+log/91d158b0a61e..a147ae2d4adc 2026-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6a86f2fce200 to 2177dbbd326b (2 revisions) 2026-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 71ead6fdeb53 to ad96e4bb5071 (13 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC bungeman@google.com,jimgraham@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#182432) https://dart.googlesource.com/sdk.git/+log/f82ec89435f5..294e6e248512 2026-02-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-150.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/a147ae2d4adc..a3a82d359a7b 2026-02-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 2177dbbd326b to 80b7d629489f (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC jimgraham@google.com,kjlubick@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/a3a82d359a7b..b7cea4cbe546 2026-02-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SKP CIPD package from 552 to 553 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC jimgraham@google.com,kjlubick@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…... (flutter#182445) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter Please CC jimgraham@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/b7cea4cbe546..94d5d5e5f785 2026-02-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 80b7d629489f to 04048f075303 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC jimgraham@google.com,kjlubick@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#182448) https://dart.googlesource.com/sdk.git/+log/294e6e248512..f2289e13a20a 2026-02-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-151.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#182462) https://dart.googlesource.com/sdk.git/+log/f2289e13a20a..c819ebe0cbe3 2026-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-152.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…2463) https://skia.googlesource.com/skia.git/+log/94d5d5e5f785..5c8a6641902f 2026-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8ff522b74b01 to db23e5d58c86 (8 revisions) 2026-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 48f5ceeea3ef to 1a3afc99a7ef (2 revisions) 2026-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 959c34d2cdd3 to 44807f17a4cc 2026-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from af6d4026789b to 4dc2907743fd 2026-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from dd6a75180b0b to 8e3b6d97c1c6 2026-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 9c6712732384 to 1b7f09f5d7a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC jimgraham@google.com,kjlubick@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/5c8a6641902f..24c7b6f5760f 2026-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 04048f075303 to 9920252190c8 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC jimgraham@google.com,kjlubick@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Feat: Add routes and transitionBuilder support in TestWidgetsApp part of: flutter#177415 As many test might need navigation with routes, we need to expose route from WidgetApp to TestWidgetsApp. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
…#182472) https://dart.googlesource.com/sdk.git/+log/c819ebe0cbe3..ff57548fcf54 2026-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-153.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…... (flutter#182478) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter Please CC jimgraham@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#182479) https://dart.googlesource.com/sdk.git/+log/ff57548fcf54..44895e617182 2026-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-154.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#183064) https://dart.googlesource.com/sdk.git/+log/cdf45eaf995e..8063f5f5ac60 2026-02-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-198.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC codefu@google.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…... (flutter#183076) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter Please CC codefu@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/28172a4e03af..b9210eb7005f 2026-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SKP CIPD package from 554 to 555 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC codefu@google.com,kjlubick@google.com,nicolettep@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…er#182971) Wait 100ms for the frame, then just continue with a warning. This should not occur, change is to help detect any bugs we might have and stop Flutter apps from potentially locking up.
) https://skia.googlesource.com/skia.git/+log/b9210eb7005f..be1362b5ca4e 2026-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from d5692ff2fb57 to 37a53b346d18 (23 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC codefu@google.com,kjlubick@google.com,nicolettep@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/be1362b5ca4e..4cf3cd27b620 2026-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 62f0f79b7d4d to 8807d22fb5c5 (22 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC codefu@google.com,kjlubick@google.com,nicolettep@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This is a documentation fix only. In [this PR](https://github.com/flutter/flutter/pull/172330/changes#diff-b5a9fc8e7a9ca4c2b2f825467a7b9cad411053d33f6e78f72875fcd6a2aae993L45), the Linux shell no longer creates a GL context with `gdk_window_create_gl_context` (it now creates its own EGL context directly). This means that the documentation in `fl_texture_gl.h` is no longer correct; it is not possible to create a shared context in this way. I filed flutter#182998 simply to support this PR. ## Pre-launch Checklist - [Y] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [Y] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [Y] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [Y] I signed the [CLA]. - [Y] I listed at least one issue that this PR fixes in the description above. - [Y] I updated/added relevant documentation (doc comments with `///`). - [N] I added new tests to check the change I am making, or this PR is [test-exempt]. - [Y] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [Y] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
…... (flutter#183101) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter Please CC codefu@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/4cf3cd27b620..cc8ce92481f2 2026-03-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dd5ab0120a15 to bd2a0f8993f5 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC codefu@google.com,kjlubick@google.com,nicolettep@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…3103) https://skia.googlesource.com/skia.git/+log/cc8ce92481f2..61c0e71760f5 2026-03-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 451d5bbc86ae to 914c428338ff 2026-03-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 4be913bfbea5 to 0c340feb28bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC codefu@google.com,kjlubick@google.com,nicolettep@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
- Adds an overview at the top about how triage works from a very high level. Right now the page discusses primary and secondary/team triage without ever actually introducing those concepts. Also sets some expectations around timelines, as we do for reviews in other docs. - Clarifies that some sub-sections of the team assignment flow chart are additional steps rather than alternate path (especially since the intro says to stop once a team assignment matches, so it was unclear that the sub-bullets applied as well). - Adds more discussion of common labels. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…r#183117) flutter/packages@a27d7c5...faa4e22 2026-03-02 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the test-dependencies group across 14 directories with 1 update (flutter/packages#11152) 2026-02-28 srawlins@google.com [pigeon] Reduce reply-handling duplication in generated Dart code. (flutter/packages#11114) 2026-02-27 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes lossless transition from Dart Color to native UIColor when calling `setBackgroundColor` (flutter/packages#10610) 2026-02-27 engine-flutter-autoroll@skia.org Roll Flutter from b31548f to 1141b2b (56 revisions) (flutter/packages#11137) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/61c0e71760f5..e180358b7a7a 2026-03-02 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 37a53b346d18 to bc602f0c897d (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC codefu@google.com,kjlubick@google.com,nicolettep@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#183120) https://dart.googlesource.com/sdk.git/+log/8063f5f5ac60..e86dbe9aa742 2026-03-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-199.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC codefu@google.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fix a few issues in the primary rules file: - Replaces a reference to a non-existent `navigation.md` file. - Fixes a grammar issue in the discussion about function length. - Removes duplicate mentions in the "UI Theming and Styling Code" section. - Removes accidental `Image.network` example inclusion in the "UI Theming and Styling Code" section. - Finish unfinished sentence about "Text Fields".
This PR turns SwiftPM on by default. This will opt users into SwiftPM and auto-migrate their project if it hasn't already been migrated. Users can still opt-out using these instructions: https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-app-developers#how-to-turn-off-swift-package-manager Fixes flutter#151567. Validated a bunch of non-presubmit test: - [x] [Mac flavors_test_macos](https://ci.chromium.org/b/8688777896504775697) - [x] [Mac integration_ui_test_test_macos](https://ci.chromium.org/b/8688777776881743345) - [x] [Mac platform_channel_sample_test_macos](https://ci.chromium.org/b/8688777747514736049) - [x] [Mac native_assets_ios_simulator](https://ci.chromium.org/b/8688773882663309793) - [x] [Mac_arm64 build_ios_framework_module_test](https://ci.chromium.org/b/8688777538801602449) - [x] [Mac_arm64 build_tests_1_4](https://ci.chromium.org/b/8688777432424952049) - [x] [Mac_arm64 plugin_lint_mac](https://ci.chromium.org/b/8688771010490841873) - [x] [Mac_arm64 hot_mode_dev_cycle_macos_target__benchmark](https://ci.chromium.org/b/8688777338792293857) - [x] [Mac_arm64 ios_app_with_extensions_test](https://ci.chromium.org/b/8688777319802762593) - [x] [Mac_arm64 macos_chrome_dev_mode](https://ci.chromium.org/b/8688777273798323777) - [x] [Mac_arm64 run_release_test_macos](https://ci.chromium.org/b/8688777255514805665) - [x] [Mac_arm64 mac_desktop_impeller](https://ci.chromium.org/b/8688775259036455505) - [x] [Mac_benchmark animated_complex_opacity_perf_macos__e2e_summary](https://ci.chromium.org/b/8688775233497234865) - [x] [Mac_benchmark basic_material_app_macos__compile](https://ci.chromium.org/b/8688775212414596785) - [x] [Mac_benchmark complex_layout_macos__start_up](https://ci.chromium.org/b/8688775198181888337) - [x] [Mac_benchmark complex_layout_scroll_perf_macos__timeline_summary](https://ci.chromium.org/b/8688773850790996993) - [x] [Mac_benchmark flutter_gallery_macos__compile](https://ci.chromium.org/b/8688773826409129377) - [x] [Mac_benchmark flutter_view_macos__start_up](https://ci.chromium.org/b/8688773773112767985) - [x] [Mac_benchmark hello_world_macos__compile](https://ci.chromium.org/b/8688773760727269169) - [x] [Mac_benchmark platform_view_macos__start_up](https://ci.chromium.org/b/8688773747621428417) - [x] [Mac_benchmark flutter_tool_startup__macos](https://ci.chromium.org/b/8688773787344192513) - [x] [Mac_x64 build_tests_1_4](https://ci.chromium.org/b/8688777231345770529) - [x] [Mac_x64 build_tests_2_4](https://ci.chromium.org/b/8688777216497738385) - [x] [Mac_x64 build_tests_3_4](https://ci.chromium.org/b/8688777202214369297) - [x] [Mac_x64 build_tests_4_4](https://ci.chromium.org/b/8688777185647496737) - [x] [Mac_x64 ios_app_with_extensions_test](https://ci.chromium.org/b/8688774621940143137) - [x] [Mac_x64 macos_chrome_dev_mode](https://ci.chromium.org/b/8688774597462648785) - [x] [Mac_ios animated_advanced_blend_perf_ios__timeline_summary](https://ci.chromium.org/b/8688777094221131537) - [x] [Mac_ios rrect_blur_perf_ios__timeline_summary](https://ci.chromium.org/b/8688777064000087553) - [x] [Mac_ios draw_arcs_all_fill_styles_perf_ios__timeline_summary](https://ci.chromium.org/b/8688777041025200385) - [x] [Mac_ios draw_arcs_all_stroke_styles_perf_ios__timeline_summary](https://ci.chromium.org/b/8688775537970255681) - [x] [Mac_ios draw_vertices_perf_ios__timeline_summary](https://ci.chromium.org/b/8688775520935099585) - [x] [Mac_ios draw_atlas_perf_ios__timeline_summary](https://ci.chromium.org/b/8688775504958221105) - [x] [Mac_ios static_path_tessellation_perf_ios__timeline_summary](https://ci.chromium.org/b/8688774736260046321) - [x] [Mac_ios dynamic_path_tessellation_perf_ios__timeline_summary](https://ci.chromium.org/b/8688774713031979665) - [x] [Mac_ios static_path_stroke_tessellation_perf_ios__timeline_summary](https://ci.chromium.org/b/8688774695482874273) - [x] [Mac_ios dynamic_path_stroke_tessellation_perf_ios__timeline_summary](https://ci.chromium.org/b/8688773629669853585) - [x] [Mac_ios animation_with_microtasks_perf_ios__timeline_summary](https://ci.chromium.org/b/8688773601089597473) - [x] [Mac_ios backdrop_filter_perf_ios__timeline_summary](https://ci.chromium.org/b/8688773584942724897) - [x] [Mac_ios channels_integration_test_ios](https://ci.chromium.org/b/8688773571254087873) - [x] Mac_ios complex_layout_scroll_perf_ios__timeline_summary - [x] [Mac_ios color_filter_and_fade_perf_ios__e2e_summary](https://ci.chromium.org/b/8688773166210725681) - [x] [Mac_ios imagefiltered_transform_animation_perf_ios__timeline_summary](https://ci.chromium.org/b/8688773151009869025) - [x] [Mac_ios external_ui_integration_test_ios](https://ci.chromium.org/b/8688773134565476161) - [x] Mac_ios route_test_ios - [ ] [Mac_ios flavors_test_ios](https://ci.chromium.org/b/8688769248121472465) - [x] Mac_ios flutter_gallery_ios__start_up - [x] Mac_ios flutter_view_ios__start_up - [x] Mac_ios integration_ui_ios_keyboard_resize - [x] [Mac_ios ios_defines_test](https://ci.chromium.org/b/8688774071442762129) - [x] Mac_ios ios_platform_view_tests - [x] [Mac_ios large_image_changer_perf_ios](https://ci.chromium.org/b/8688774031240051537) - [x] [Mac_ios microbenchmarks_ios](https://ci.chromium.org/b/8688774547634994785) - [x] Mac_ios native_assets_ios - [x] [Mac_ios new_gallery_skia_ios__transition_perf](https://ci.chromium.org/b/8688776417509425425) - [x] [Mac_ios platform_channel_sample_test_ios](https://ci.chromium.org/b/8688772159495774417) - [x] Mac_ios platform_channels_benchmarks_ios - [x] [Mac_ios platform_interaction_test_ios](https://ci.chromium.org/b/8688772132549031473) - [x] Mac_ios platform_view_ios__start_up - [x] [Mac_ios platform_views_scroll_perf_ios__timeline_summary](https://ci.chromium.org/b/8688770924854937297) - [x] [Mac_ios platform_views_scroll_perf_ad_banners__timeline_summary](https://ci.chromium.org/b/8688770911202009137) - [x] [Mac_ios platform_views_scroll_perf_bottom_ad_banner__timeline_summary](https://ci.chromium.org/b/8688770895354090081) - [x] [Mac_ios platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary](https://ci.chromium.org/b/8688770878784490225) - [x] [Mac_ios post_backdrop_filter_perf_ios__timeline_summary](https://ci.chromium.org/b/8688770864215965681) - [x] [Mac_ios wide_gamut_ios](https://ci.chromium.org/b/8688772092281083761) - [x] [Mac_ios ios_debug_workflow](https://ci.chromium.org/b/8688773991399243601) - [x] Mac_ios very_long_picture_scrolling_perf_ios__e2e_summary - [x] Mac_ios spell_check_test - [x] [Mac_x64_ios integration_test_test_ios](https://ci.chromium.org/b/8688772067540844481) - [x] [Mac_x64_ios hot_mode_dev_cycle_ios__benchmark](https://ci.chromium.org/b/8688772048988479185) - [x] [Mac_arm64_ios basic_material_app_ios__compile](https://ci.chromium.org/b/8688772023490349601) - [x] [Mac_arm64_ios flutter_gallery_ios__compile](https://ci.chromium.org/b/8688772011072284625) - [x] [Mac_arm64_ios hello_world_ios__compile](https://ci.chromium.org/b/8688771998203648913) - [x] [Mac_arm64_ios imitation_game_flutter](https://ci.chromium.org/b/8688771982414426593) - [x] [Mac_arm64_ios imitation_game_swiftui](https://ci.chromium.org/b/8688771968308027601) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This PR was generated by `flutter update-packages --force-upgrade`. --------- Co-authored-by: Gray Mackall <mackall@google.com>
…er#183070) ## Description Make `TextDecoration` a `final class` and add the `maskValue` getter to the non-web implementation for API consistency. ### Problem `TextDecoration` has a platform-inconsistent API: the web implementation exposes a `maskValue` getter (used by Skwasm) that the non-web implementation does not. Code that `implements TextDecoration` compiles on mobile but fails on web due to the missing `maskValue`. ### Solution 1. Make `TextDecoration` a `final class` in both web and non-web implementations to prevent external extension/implementation 2. Add `maskValue` getter to the non-web implementation so the public API is consistent across platforms As @jason-simmons suggested, adding `maskValue` to the non-web side provides consistency, similar to how enum-based text style attributes expose their `index` property. ## Changes - `engine/src/flutter/lib/ui/text.dart`: `class` → `final class`, add `maskValue` getter - `engine/src/flutter/lib/web_ui/lib/text.dart`: `class` → `final class` (already has `maskValue`) - `engine/src/flutter/testing/dart/text_test.dart`: add `testTextDecoration` verifying `maskValue` for predefined and combined decorations No usages of `extends TextDecoration` or `implements TextDecoration` exist in the codebase, so the `final` change has no internal impact. ## Tests Added 3 test cases in `engine/src/flutter/testing/dart/text_test.dart`: - `maskValue` returns correct bit mask for each predefined decoration (`none`, `underline`, `overline`, `lineThrough`) - `maskValue` returns combined bit mask for `TextDecoration.combine` with partial decorations - `maskValue` returns combined bit mask for all decorations combined ## Related Issue Closes flutter#181662 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added tests to cover the new `maskValue` getter. - [x] I updated/added relevant documentation (doc comments, etc.) cc @mdebbar @jason-simmons [Contributor Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [Flutter Style Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
…3130) https://skia.googlesource.com/skia.git/+log/e180358b7a7a..f886711f180d 2026-03-02 michaelludwig@google.com [graphite] Guard texture-to-texture copy with format check 2026-03-02 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 8807d22fb5c5 to 425ea1de41aa (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC codefu@google.com,kjlubick@google.com,nicolettep@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…ch (flutter#183132) The action to merge the changelog from stable to master was failing because it couldn't find the `stable` branch. This PR updates the action to explicitly fetch the `stable` branch and avoid a deep clone of all branches using `fetch-depth: 0` in `actions/checkout`.
- Add documentation - Use enums - Make _FlEngine object - Moved FFI code to the bottom of the file - it can't be easily split into a separate file without being made public.
This PR was generated by `flutter update-packages --force-upgrade`.
Impl:
```dart
/// Sends the specified [message] to the platform plugins on this channel.
///
/// Returns a [Future] which completes to the received response, which may
/// be null.
Future<T?> send(T message) async {
return codec.decodeMessage(await binaryMessenger.send(name, codec.encodeMessage(message)));
}
```
Part of flutter#181513
…mn pinned (flutter#180563) ### Description This PR addresses a critical performance issue where the TableView component experiences severe lag when scrolling to row 15,000 with both the first row and first column pinned. ### Root Cause The _reifyChildren method in RenderTwoDimensionalViewport was consuming excessive CPU resources due to inefficient iteration logic: It used nested for-loops starting from index 0, iterating through all rows (0 ~ 15K) even when only 4 rows/columns were visible on screen The pinned first row/column caused unnecessary full-range iteration instead of limiting to the visible viewport ### Solution Optimized the iteration logic in _reifyChildren: Store only viewport-visible children in _currentChildVicinities Restrict ParentData calculations in _reifyChildren to only the children within _currentChildVicinities Eliminated full-range (0 ~ 15K) iterations and focused only on visible elements ### Fixes:flutter#138271 Important Note: This fix exclusively resolves the jank associated with pinned rows and columns; the jank in non-pinned scenarios stems from a different root cause and is not included in this commit. ### Video performance comparison before： https://github.com/user-attachments/assets/b0892dd5-858b-44a6-8f26-37803ce50452 after： https://github.com/user-attachments/assets/7a6cddf2-04bf-465d-9997-3fdcab5692f7 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
This code was never testing that the exception was a DOMException. When compiling to JS, this is just checking if it is a JS object and when compiling to Wasm, this is just checking if the value is a JS value. With recent [lint changes](https://dart-review.googlesource.com/c/sdk/+/483960), this will now be linted and will therefore block the SDK roll. Instead, we should catch the exception without a type, do an isA check (now that it supports arbitrary values), and then rethrow if it isn't the exception we were looking for. Note that this does mean if this code was accidentally catching a different JS value before, it now rethrows it. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].
- Updated Podfile to use local engine instead of cached - Added debug engine path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.