Bold and italics within code blocks aren't recognized#57
Open
fmarier wants to merge 1 commit intoaaronsw:masterfrom
Open
Bold and italics within code blocks aren't recognized#57fmarier wants to merge 1 commit intoaaronsw:masterfrom
fmarier wants to merge 1 commit intoaaronsw:masterfrom
Conversation
Pass them through as raw HTML instead.
Owner
|
What's the use case for this? I'm having trouble understanding why you'd want this result. |
Contributor
Author
|
That patch (and the other ones) comes from my Blogger-to-Ikiwiki conversion script. On my blog, I've got code samples where I highlight particular pieces by making them bold or italics. |
Owner
|
Yeah, but in standard Markdown indented HTML tags get escaped. So this doesn't seem like it would help. Is this not true with ikiwiki? |
Contributor
Author
|
Hm, you're right. I just tried it with the normal markdown cli tool and the above test case produces this mess: which isn't even consistent. In the ikiwiki parser, it lets these tags through. In fact I have more hacks that take advantage of that. |
pombredanne
pushed a commit
to pombredanne/html2text
that referenced
this pull request
Oct 10, 2015
Retain escaping of html except within code or pre tags. Thanks Scott Blackburn @smblackburn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass them through as raw HTML instead.