Refactor App.cpp and update tests for modularity #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 28, 2024 19:31
Refactored App.cpp to improve modularity and readability: - Replaced `getValidatedInput` with `readValidatedInteger` - Added `writeOutput`, `readInput`, and `formatRollResults` - Refactored `handleTargetRoll` and `handleOpposedRoll` - Added `showManual` function - Updated `runCoreRoller` for cleaner user choice handling Updated test_dice.cpp to include tests for new functions: - Added `setInput` and `captureOutput` helpers - Added tests for `readValidatedInteger`, `handleOpposedRoll`, and `handleTargetRoll` - Enhanced tests for `rollDice`, `opposedRoll`, and `targetRoll` Created App.h to declare functions used in App.cpp.
- Added a static library target named `Core` in the `CMakeLists.txt` file. - Included the `Core/Source` directory in the public include directories for the `Core` library. - Added an executable target named `App` with source files `App/Source/App.cpp` and `App/Source/App.h`. - Ensured that the `App` target includes the `Core/Source` directory in its private include directories. - Linked the `App` target with the `Core` library. - Enabled testing in the `CMakeLists.txt` file. - Added an executable target named `tests` with the source file `tests/test_dice.cpp`. - Updated the include directories for the `tests` target to include both `Core/Source` and `App/Source` directories. - Linked the `tests` target with the `Core` library and `gtest_main`. - Added the `tests` executable to CTest with the name `CoreTests`. - Modified the `test_dice.cpp` file to include the correct path for the `App.h` header file by changing `#include "App.h"` to `#include "Source/App.h"`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored App.cpp to improve modularity and readability:
getValidatedInputwithreadValidatedIntegerwriteOutput,readInput, andformatRollResultshandleTargetRollandhandleOpposedRollshowManualfunctionrunCoreRollerfor cleaner user choice handlingUpdated test_dice.cpp to include tests for new functions:
setInputandcaptureOutputhelpersreadValidatedInteger,handleOpposedRoll, andhandleTargetRollrollDice,opposedRoll, andtargetRollCreated App.h to declare functions used in App.cpp.