Skip to content

Comments

Update Command_smite.java#395

Closed
GaastCoding wants to merge 1 commit intoTotalFreedom:masterfrom
GaastCoding:master
Closed

Update Command_smite.java#395
GaastCoding wants to merge 1 commit intoTotalFreedom:masterfrom
GaastCoding:master

Conversation

@GaastCoding
Copy link

Add a reason parameter, this will now broadcast the reason in yellow that is specified within args[1].

Add a reason parameter, this will now broadcast the reason in yellow that is specified within args[1].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage for a required argument is: "", usage for an optional argument is: "[arg]"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is fine then because we want it to be optional (according to your other comment anyway...)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wild1145 "playername" should modified to be a required argument. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeromSar So it should. I was only looking at the changes that were made, thats why I missed it :P

@JeromSar
Copy link
Member

JeromSar commented Jan 9, 2015

Your PR does not include "Close #393" in the commit message which is required as per the Contribution Guidelines. Please update your PR accordingly. :)

@JeromSar
Copy link
Member

@GaastCoding Are you going to be updating this?

@JeromSar
Copy link
Member

@GaastCoding Last update request. Closing for inactivity soon.

@mgejay
Copy link

mgejay commented Apr 11, 2015

Ill make some changes.

@Wild1145
Copy link
Member

@TheRevalation Can we get an update on this? Its quite an old issue now :)

@mgejay
Copy link

mgejay commented Apr 24, 2015

@Wild1145 There is an updated PR for this #556

@Wild1145
Copy link
Member

@JeromSar Requesting this be closed for inactivity, plus there is a newer issue open as @TheRevalation has pointed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants