Open
Conversation
Owner
Author
|
Reopen the pull request for the approval. |
dwz92
approved these changes
Sep 5, 2024
dwz92
left a comment
There was a problem hiding this comment.
I'll approve this, but for better practice next time, don't use cd and simply specify dir2 in your file path
Owner
Author
|
Thanks Emma for your comments and help!
Sincerely,
Tina Lin
…________________________________
发件人: Emma ***@***.***>
发送时间: 2024年9月5日 21:45
收件人: TinaToronto/shell ***@***.***>
抄送: TinaToronto ***@***.***>; State change ***@***.***>
主题: Re: [TinaToronto/shell] Update assignment.sh based on the feedback (PR #2)
@dwz92 approved this pull request.
I'll approve this, but for better practice next time, don't use cd and simply specify dir2 in your file path
―
Reply to this email directly, view it on GitHub<#2 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BIRJUZCZK2O2JR2IC7DSIFTZVDGHRAVCNFSM6AAAAABNVO6W5WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOBUGEZTEMJVHE>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding and removing code
What did you learn from the changes you have made?
Make the changes based on the comments
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
None
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
None
How were these changes tested?
VS
A reference to a related issue in your repository (if applicable)
None
Checklist
Yes