Skip to content

Conversation

@TestingCodeReview
Copy link
Owner

Bring fork up to date with main repo.

@deepcodeappdev
Copy link

deepcodeappdev bot commented Oct 14, 2020

DeepCode's analysis on #30fd32 found:

  • 2 critical issues, ⚠️ 6 warnings, ℹ️ 6 minor issues. 👇
  • ✔️ 7 issues were fixed.

Top issues

Description Example fixes
Unsanitized input from data from a remote resource flows into append, where it is used to dynamically construct the HTML page on client side. This may result in a DOM Based Cross-Site Scripting attack (DOMXSS). Occurrences: 🔧 Example fixes
Unsanitized input from data from a remote resource flows into a member access and is used to access a property of a field assignment by name. This may allow a malicious user to access methods (e.g. toString) as opposed to regular properties of objects and cause a crash, remote code execution or more serious problems. This is known as a Prototype Pollution vulnerability. Occurrences: 🔧 Example fixes
The usage of string in replace will change only the first match. Consider using a regular expression with the global replacement flag (/g) to replace all occurrences. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

eemeli and others added 29 commits April 25, 2022 17:16
* chore: Add `curly: error` to ESLint configs

* style: Apply updated linter rules
Warm-reloading is not even used by the core Pontoon devs.
It also has poor browser support and requires hacking.
* chore: Refresh lockfile

Also apply minor Prettier style update

* chore: Update to sinon 13

* test: Add MockLocalizationProvider, wrapping all Localized components in tests

* chore(translate): Update Fluent packages
* Add missing Fluent messages to en-US

* Only call react-infinite-scroll-hook rootRef() when necessary
* Add pretranslation_enabled field to ProjectLocale

* Render Pretranslation locale selector

* Only pretranslate selected locales

* Remove extra comma and unify styling

* Propagate pretranslation_enabled from Project to its ProjectLocales
* Make celery command version 5.x compatible

This is a regression from #2498.

* Update docs according to celery version 5
* refactor: Simplify core/entities exports & usage

* refactor: Simplify core/resource exports & usage

* refactor: Simplify modules/batchactions exports & usage

* refactor: Simplify arguments for api.entity.getEntities() and its callers

* refactor: Simplify core/stats exports & usage

* refactor: Simplify <App> props

* refactor: Simplify core/project exports & usage

* refactor: Simplify <Navigation> logic & props

* refactor: Simplify <UserControls> props

In addition to UnsavedChanges, this was the only remaining
component using connect(), which was causing some issues in
mocking.

* refactor: Simplify modules/unsavedchanges exports & usage
Microsoft Terminology Service endpoint is down ATM:
https://api.terminology.microsoft.com/Terminology.svc

It is essentially making the translate app unusable, because many
requests are timing out.

This is just a temporary fix to disable the service. The proper fix, which will
prevent external services to affect other requests, will come in a followup.
* style: Do not use default exports

* chore: Add ESLint rule import/no-default-export
Drops unused always-false "visible" field from output
* Add support for list query parameter
* Use list parameter in review-notification links
* Fix small issues with comments, splitting MentionList from AddComment

* refactor: Turn addComment() action into useAddCommentAndRefresh() hook
dependabot bot and others added 28 commits July 19, 2023 09:56
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pygments](https://github.com/pygments/pygments) from 2.7.4 to 2.15.0.
- [Release notes](https://github.com/pygments/pygments/releases)
- [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES)
- [Commits](pygments/pygments@2.7.4...2.15.0)

---
updated-dependencies:
- dependency-name: pygments
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add Slug History and Redirect for Project Model

* Handle project URL slug changes in project view

* Satisfying linters

* Modified structure and decorator

* Satisfying linters

* Updated decorator to pass the list of kwargs needed for the redirect

* Adding tests for the Project view and the Translate view for the decorator

* Linters

* Added new test cases for Project, Translate, and Localization view slug redirection logic and enhanced docstrings

* Optimize project slug history lookup and handle slug reuse scenarios

* Refactored project slug redirection logic from decorator to utility function get_project_or_redirect

* Refactor imports and replace get_object_or_404 with standard try/except
* Add Request pretranslation button

* When clicked, the button shows a list of available projects that can be selected via checkbox

* When selecting one or more projects, the following text is displayed at the bottom of the list

* Use highlight color for links in the text at the bottom of the list

* This text is followed by a REQUEST PRETRANSLATION button. When clicked, the button’s text changes to ARE YOU SURE?, asking for a confirmation before sending the actual request.

* Add missing spaces

* Fix request pretranslation button condition

* At the end of the process, an email is sent

* Apply suggestions from code review

Co-authored-by: Eemeli Aro <eemeli@gmail.com>

* Fix prettier

* More modern JS

* Temporarily disable the ability to Request Pretranslation

---------

Co-authored-by: Eemeli Aro <eemeli@gmail.com>
* Do not enforce camel case on sibling entity object keys

* Fix linter issue introduced in #2900
…itor results have updated (#2917)

* Replace editor `<textarea>` with CodeMirror v6

* refactor: Add EditFieldHandle and EditorResult as interfaces for the editor value

* Add syntax highlighting for placeholders and tags

* Re-enable spellchecker in translation editor (#2884)

* Delay setting failed checks until editor results have updated

* Update tests to account for setTimeout

* Scroll editor settings menu into view on display

---------

Co-authored-by: Matjaž Horvat <matjaz.horvat@gmail.com>
…2912)

* Adding 'date_created' to Entity and Display in Metadata

* Add validation check for date in EntityCreatedDate component

* Updating date_created field to string

* Add default date_created to ENTITY objects in tests

* Satisfying prettier

* adding suggested changes
Also included:
* Time to review suggestions and Age of unreviewed suggestions charts are split into separate panels
* Remove the 2021-specific argument & logic after the year ends
* Change defaut value in "Time to review" charts from 0 to None and in return calculate averages properly
* ENABLE_INSIGHTS_TAB -> ENABLE_INSIGHTS
* insights.{css,js} -> insights_tab.{css,js}
* Restore chart group on the Profile page
* Move Custom legend to insights_charts CSS/JS
* Only show clicked dataset when holding Alt or Command key
@mathjazz mathjazz deleted the branch TestingCodeReview:master September 19, 2023 11:38
@mathjazz mathjazz deleted the master branch September 19, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.