Match function prototypes from TwoWire #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the overloads to be called correctly through a TwoWire pointer. In particular, endTransmission and RequestFrom didn't match the TwoWire prototypes, which causes issues when attempting to call through a pointer.
Author
|
Won't help right now since currently TwoWire methods aren't virtual. However, I've put in a PR there to make them virtual for this: arduino/ArduinoCore-avr#331 In the mean time, it shouldn't hurt |
Owner
|
closed due to #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the overloads to be called correctly through a TwoWire pointer. In particular, endTransmission and RequestFrom didn't match the TwoWire prototypes, which causes issues when attempting to call through a pointer to a TwoWire object.