allow input options without value #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use yajl-ruby for JSON parsing
Additionally, refactor the Open3 stub methods to provide the corrected stdout vs stderr. ffprobe provides its output on stdout instead of stderr which is where it had been retreived previously.
Because ffprobe does not return a decimal frame per second and instead returns a rational number there is no need for this test. Also, the colorspace returned in its own field. Therefore, regular expression gymnastics are no longer requred.
ffprobe returns its frame rate as a rational number as opposed to a floating point (e.g., 24600/1469 instead of 16.75). This allows the number to maintain a higher precision but is somewhat of a breaking change for the specs and thus the API. ffprobe's default units are bit/s instead of the old ffmpeg output being in kb/s. Again, higher precision but a breaking change for the specs and thus the API. ffprobe does not provide a property like FFMPEG::Movie#video_stream or FFMPEG::Movie#audio_stream. Therefore, an attempt to emulate it and provide backwards compatibility is provided.
… rotation feature for iOS (SHA 9267eee)
…anges made to apply to his fork
… up screenshot generation by a huge factor as it avoids repeated seeks through large files.
…se of String options was removed in 2.1.0 when the transcoder options were no longer passed through shell.
…reviously hung. Closes streamio#107.
sudo is not recommended for gem install require 'rubygems' is not needed anymore consistent hash syntax and a little bit more readability improvement
…edirect_attempts”
can be passed through to the remote host.
Just fix the typo in the Readme)
According to https://trac.ffmpeg.org/ticket/3798 ffprobe `might` return `0:1` as dar/sar, which they mean `invalid/unset` Make sure we don’t trust that value, even on the rotated movie. closes streamio#150, closes streamio#151
But keep the backwards compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow passing input option -re in front of the input path, otherwise ffmpeg will complain.
This is on top of #1
Must be checked out and force pushed to master since at some point they diverged