Skip to content

DONT MERGE: Issues with Gemfile.lock on winbuild servers#253

Closed
gbrayut wants to merge 3 commits intomasterfrom
3.2.1_winbuild
Closed

DONT MERGE: Issues with Gemfile.lock on winbuild servers#253
gbrayut wants to merge 3 commits intomasterfrom
3.2.1_winbuild

Conversation

@gbrayut
Copy link
Contributor

@gbrayut gbrayut commented Oct 4, 2016

@clipperhouse So it looks like we can't share a .lock file between Windows and Mac. Probably doesn't matter, as our build serves should be static. Here are the differences between the two files.

Right now I have the build delete the .lock file, so if you want to leave it in for use by authors that is fine b me.

We can chat about this and next steps tomorrow

clipperhouse and others added 3 commits October 4, 2016 18:03
…stems.

Here are the differences on our winbuild servers. Not sure we actually need it on the build servers, right now I delete it as part of the build.
@gbrayut
Copy link
Contributor Author

gbrayut commented Oct 5, 2016

Oh and the build complains about jekyll-watch, which we don't use there but may be used locally. I think the gem may not be needed anymore, as it is built in. May want to try removing it from the gem files.

@dgreenley
Copy link
Contributor

FWIW, this removes the file: _posts/2015-08-21-Welcome-Juan-Garza-and-Stack-Overflow-En-Español!.md which I suspect was unintended.

Very much not the expert but I was having issues with that file on my OSX box, thanks to the special character, until I did:
git config core.quotePath false
and
git config --global core.precomposeunicode true
as per http://stackoverflow.com/questions/34549040/git-not-displaying-unicode-file-names

@gbrayut
Copy link
Contributor Author

gbrayut commented Oct 5, 2016

yeah... not sure why that is there... This won't be merged so don't worry about it.

Only here to show Matt the different gemlock file

@clipperhouse
Copy link
Contributor

@gbrayut OK sounds like we shouldn't share a lock file, i.e., the build simply calls calls jekyll and has no interest in this repo's Gemfile.lock. Feasible?

@gbrayut
Copy link
Contributor Author

gbrayut commented Oct 5, 2016

Definitely can't have one on the build server as it causes issues, but I'm fine deleting the one from the repo as part of the build if needed. If there is value in having a shared lock for authors then we can keep it. I may also add a Gemfile.winbuild.lock that shows the version numbers on the build server.

I'm not familiar with Ruby/Gemfiles much, so I'll ask around and see what is normally done.

@gbrayut
Copy link
Contributor Author

gbrayut commented Oct 10, 2016

Lock files were renamed so they can be used for reference but won't effect the build.

Live in CO, Staged in NY for deployment this week.

@gbrayut gbrayut closed this Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants