Claude/specificationcore #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
operators - Created independent SpecificationCore package with core protocols, specs, context, wrappers, macros, and tests - Refactored SpecificationKit to depend on SpecificationCore locally, removed duplicate core files, and added re-export for backward compatibility - Restored missing SpecificationOperators.swift in SpecificationCore to fix DSL operator compilation failures and ensure all tests pass - Updated documentation and progress tracking to reflect completion with zero regressions
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…cationCore ## Summary Moved to SpecificationCore/Tests/SpecificationCoreTests/WrapperTests/: 1. SatisfiesWrapperTests.swift - Tests for the @Satisfies property wrapper (10 tests) 2. DecidesWrapperTests.swift - Tests for the @decides property wrapper (9 tests) 3. MaybeWrapperTests.swift - Tests for the @maybe property wrapper (5 tests) 4. AsyncSatisfiesWrapperTests.swift - Tests for async specification evaluation (2 tests) Moved to SpecificationCore/Tests/SpecificationCoreTests/SpecTests/: 5. FirstMatchSpecTests.swift - Tests for FirstMatchSpec decision specification (5 tests) 6. DecisionSpecTests.swift - Tests for decision specification protocols (7 tests) 7. DateComparisonSpecTests.swift - Tests for date comparison specs (1 test) 8. DateRangeSpecTests.swift - Tests for date range specs (1 test) 9. AnySpecificationPerformanceTests.swift - Performance tests for type-erased wrappers (11 tests) Test Results: - SpecificationCore: All 65 tests passing ✓ - SpecificationKit: All 514 tests passing ✓ - All imports updated from @testable import SpecificationKit to @testable import SpecificationCore - Old test files removed from SpecificationKit The core functionality tests now properly reside in the SpecificationCore module, while SpecificationKit retains tests for its extended features (macros, observed wrappers, platform providers, etc.).
…onCore on branch "claude/specificationcore"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract Core features into the new SPM - SpecificationCore