Fix build for MacOS and upload artifacts with custom directory #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies file path references in GitHub Actions workflow configuration by removing redundant directory prefixes and updating wildcard patterns. The changes improve maintainability by leveraging the existing working-directory setting instead of repeating full paths.
- Removed explicit
${{ inputs.app-working-directory }}prefixes from macOS build commands sinceworking-directoryis already set - Updated wildcard patterns from single-level (
*/) to multi-level (**/) for more flexible path matching in artifact handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies file path references in the
action.ymlfile to improve maintainability and consistency. The changes primarily focus on removing redundant directory prefixes and standardizing path patterns.Simplifications in file path references:
runs:to remove explicit references to${{ inputs.app-working-directory }}for macOS build and signing commands, simplifying the paths to relative references likebuild/bin/...andbuild/darwin/....runs:by replacing single-level wildcards (*/bin/and*\bin\*) with multi-level wildcards (**/bin/and**\bin\*) for better flexibility and accuracy in matching paths.