Skip to content
This repository was archived by the owner on Dec 24, 2022. It is now read-only.

Conversation

@AlexOldest
Copy link

Test block:
//.....
string s = null;
try
{
s = StringExtensions.BaseConvert("-212", 3, 10);
WriteLine(s);
s = StringExtensions.BaseConvert("312", 3, 10);
}
catch (Exception ex)
{
Console.WriteLine(ex.Message);
}
//.....

…n when wrong data supplied

Test block:
//.....
string s = null;
try
{
s = StringExtensions.BaseConvert("-212", 3, 10);
WriteLine(s);
s = StringExtensions.BaseConvert("312", 3, 10);
}
catch (Exception ex)
{
Console.WriteLine(ex.Message);
}
//.....
@mythz
Copy link
Member

mythz commented Nov 15, 2015

Hi Alex,

Cheers for this, can you approve the Contributor License Agreement so we can merge this, thx.

Could you resend this PR without using C# 6 syntax and to use spaces instead of tabs to stick to the existing code style so that the diffs can show exactly what's changed, thx.

@AlexOldest
Copy link
Author

Hi Demis,
Thank you for your response. I am new to GitHub but appreciate it very much.
I also appreciate your skill and efforts in creating and supporting ServiceStack.Text library. I intend to learn and use it as a primer when teaching students.
Help me, I have made a change to my first commit, but can't find out how to push it up.

@AlexOldest
Copy link
Author

I think that it would be easier to attach a new version of StringExtensions.BaseConvert extension-method
BaseConvert.txt

@AlexOldest AlexOldest closed this Nov 16, 2015
@mythz
Copy link
Member

mythz commented Nov 16, 2015

Hi Alex,

No worries I just applied the changes manually in this commit: b06246a

You can get this change on v4.0.47 MyGet pre-release packages now, or you can wait till tomorrow when we should be deploy the next v4.0.48 official release to NuGet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants