Skip to content

Conversation

@eddyjaga
Copy link
Collaborator

Short Description / Link to Ticket

This pull request updates the webhook client logic to dynamically select the correct base URL depending on the environment, ensuring webhooks use the appropriate endpoint in production and prelive environments. The release is versioned as 2.8.5 and includes documentation of the fix in the changelog.

Webhook base URL selection improvements:

  • Added Config#webhook_base_endpoint to return the correct endpoint for webhooks based on the environment—core_base for production and va_base for prelive. The webhook client now uses this method to set its base URL, replacing the previous hardcoded approach. [1] [2]
  • Updated documentation and comments to clarify webhook endpoint selection logic in Client.

Release and documentation:

  • Bumped the gem version to 2.8.5.
  • Added a changelog entry describing the fix and linking to the full diff.

Testing

Additional Notes

@eddyjaga eddyjaga merged commit 86ea96a into main Dec 12, 2025
2 checks passed
@eddyjaga eddyjaga deleted the feature/fix-webhook branch December 12, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants