Skip to content

Conversation

@eddyjaga
Copy link
Collaborator

@eddyjaga eddyjaga commented Nov 7, 2025

Short Description / Link to Ticket

This pull request primarily updates the handling of routing number validation responses, ensuring a consistent nested structure in the returned data and updates related documentation and tests. It also removes an unnecessary key from the response data keys and makes minor corrections to the test fixtures for virtual accounts.

Key changes include:

Routing Number Validation Response Structure:

  • Updated the routing number validation response to always return routing details nested under the 'routing_number' key, both in documentation and example code. This affects how consumers access routing information in the response. [1] [2] [3] [4] [5] [6]
  • Updated the spec for bank account routing number validation to reflect the new nested structure and added assertions for additional fields such as city, state_code, and customer_name.

Library and Versioning:

  • Removed the 'routing_number' key from the RESPONSE_DATA_KEYS array in Response, as it is no longer needed with the new response structure.
  • Bumped the gem version to 2.8.1 to reflect these changes.

Test Fixture Corrections for Virtual Accounts:

  • Flattened the virtual account test fixtures by removing unnecessary 'virtual_accounts' nesting, and updated the stubs and expectations accordingly for all virtual account specs. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

Testing

Additional Notes

@eddyjaga eddyjaga merged commit c4375b9 into main Nov 7, 2025
2 checks passed
@eddyjaga eddyjaga deleted the feature/fix-issue-for-virtual-account branch November 7, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants