Skip to content

UofT-DSI | python - Assignment 2#2

Open
Robocoph wants to merge 4 commits intomainfrom
assignment-2
Open

UofT-DSI | python - Assignment 2#2
Robocoph wants to merge 4 commits intomainfrom
assignment-2

Conversation

@Robocoph
Copy link
Owner

@Robocoph Robocoph commented May 9, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Completed the code blocks required by the assignment

What did you learn from the changes you have made?

Quite a lot actually. As someone who uses pandas read_csv or read_parquet, using the out of the box file opening function was neat

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I took a slightly different approach to checking the 60 participants, I defined inside the function because there is no point running the function if my dataset is incorrect (that's just my humble opinion)

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Nothing

How were these changes tested?

Locally, and runs fine. I did import a pprint() package but it doesn't require pip install, so you should be fine.

A reference to a related issue in your repository (if applicable)

None that I am aware of

Checklist

  • [ x ] I can confirm that my changes are working as intended

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go through the review comments and make the required changes:

  1. Its not recommended to hardcode the directory name since it makes the program non-portable. Also, changing the working directory globally with os.chdir() affects all relative paths used afterward.
    Simply replace the hardcoded absolute paths to relative paths so that a Learning support can run the code successfully as well. For example: change "python/05_src/data/assignment_2_data/inflammation_01.csv" to "../../05_src/data/assignment_2_data/inflammation_01.csv"`

  2. Changes to assignment_1.ipynb should not be included in this pull request.
    Please refer to following thread of slack https://uoft-dsi-certificates.slack.com/archives/C08JWD6RRU3/p1747084222526419 to fix this.

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now! Well done! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants