Skip to content

Fixes #1244: Keys get the name of the associated validator #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CameronHall wants to merge 2 commits into from
Closed

Fixes #1244: Keys get the name of the associated validator #1245

CameronHall wants to merge 2 commits into from

Conversation

@CameronHall
Copy link
Contributor

@CameronHall CameronHall commented Jun 19, 2019 •
edited
Loading

Fixies #1244

ItsShadowl
ItsShadowl approved these changes Jul 5, 2019
View reviewed changes
Copy link

@ItsShadowl ItsShadowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR

@CameronHall
Copy link
Contributor Author

CameronHall commented Jul 5, 2019

I'm unsure about how I've updated the test in tests/unit/Rules/AbstractRelatedTest.php. Hoping @henriquemoody can provide some input.

@henriquemoody
Copy link
Member

henriquemoody commented Jul 25, 2020

That took me a while...

I've merged it manually by fc14c6c, and it's also available on version 2.0.16.

Thanks for contributing! 🐼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ItsShadowl ItsShadowl ItsShadowl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CameronHall @henriquemoody @ItsShadowl