x.c:widget_values_get(): use a reference into a XtArgVal array. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratmice
force-pushed
the
window_close_fix
branch
from
43b3416 to
41a3a72
Compare
…_to_pairs. widget_values_get(): store values in an XtArgVal array initialized to zero. xt_args_to_pairs(): expect a pointer to a value,
ratmice
force-pushed
the
window_close_fix
branch
from
41a3a72 to
1ebf222
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its been forever since I did any C, but I believe this should fix the segfault on window close,
according to man XtGetValues,
And got rid of a malloc while there as well...
[edit 2]
The game of whack a mole continues, It appears the main issue with the original code was that
it would copy a 16 bit short into a 32 bit XtArgVal, leaving 16 bits uninitialized, then reading the 32 bit value later would make things unhappy...
I renamed args_to_pairs, since the 2 no longer expect the same kind of Arg,
the latter expects args filled with pointers, while the former expects args filled with values.
and widget_values_get is the only caller of xt_args_to_pairs.
sorry for the churn.