-
Notifications
You must be signed in to change notification settings - Fork 1
Build fixes #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rocm
Are you sure you want to change the base?
Build fixes #1
Conversation
| FLA_Error REF_Apply_Q( FLA_Side side, FLA_Uplo uplo, FLA_Trans trans, FLA_Obj A, FLA_Obj t, FLA_Obj B ) | ||
| { | ||
| return FLA_Apply( side, uplo, trans, A, t, B ); | ||
| //return FLA_Apply( side, uplo, trans, A, t, B ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reference to this. However, not having it seems to be causing a runtime issue. Will keep looking into it.
iotamudelta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor stuff
| case FLA_ALG_REFERENCE: | ||
| //FLA_Obj_show( "A_flat:", A_flat, "%12.4e", "" ); | ||
| //FLA_QR_UT( A_flat, t, T_flat ); | ||
| FLA_QR2_UT( B_flat, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this is the FLA_ALG_REFERENCE path, no FLASH substitution necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FLA_QR2_UT was giving an undefined reference. It looks like it was removed at some point. Should this be something other than FLASH_QR2_UT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does FLA_QR2_UT_internal work?
| FLASH_Norm1( B, norm ); | ||
| if ( FLA_Obj_is( isgn, FLA_MINUS_ONE ) ) | ||
| FLA_Negate( norm ); | ||
| FLASH_Obj_shift_diagonal( FLA_NO_CONJUGATE, norm, B ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting that this is not necessary
| FLASH_Copy( A_save, A ); | ||
|
|
||
| FLASH_Obj_flatten( A, A_flat ); | ||
| FLA_QR_UT( A_flat, t, T_flat ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intentional change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mistake, will fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least, leaving the old line in was. It was complaining about too many args. Since I don't have this test working correctly, I can't verify I removed the correct arg yet. But this gets the test compiling.
|
I reverted any tests that weren't working as expected. Below I'll list the status of each test. Only one actually worked as expected. util/app/qut/front/flamec/test/flash_sm util/app/qutinc/front/flamec/test/flash_sm util/app/q2ut/front/flamec/test/flash_sm sol/sylv/front/flamec/test/flash_sm dec/q/qr2ut/front/flamec/test/flash_sm |
I got the following tests building and running the without crashing:
./src/lapack/util/app/qutinc/front/flamec/test/flash_sm
./src/lapack/util/app/q2ut/front/flamec/test/flash_sm
./src/lapack/sol/sylv/front/flamec/test/flash_sm
./src/lapack/dec/q/qr2ut/front/flamec/test/flash_sm
I got this testing building, but could not find a replacement for FLA_Apply(). This seems to be causing a run time error.
./src/lapack/util/app/qut/front/flamec/test/flash_sm