-
Notifications
You must be signed in to change notification settings - Fork 23
Enable MXFP8 support in TE JAX integration #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or gfx950 ci enablement
…ed with hipblaslt
Contributor
Author
|
Note that the CI failure is unrelated. |
wangye805
requested changes
Jan 22, 2026
Collaborator
wangye805
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still many other places needs rocm specific guards
wangye805
requested changes
Jan 26, 2026
wangye805
approved these changes
Jan 29, 2026
Collaborator
wangye805
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables MXFP8 support in the TE JAX integration and significantly modifies tests to account for remaining support gaps
TODO:
test_layernorm_mlp_grad{_shardy}when using hipblaslt GEMM + bias + no scaling + bf16 dtypeFixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
tests/jax/test_custom_call_compute.pytest_custom_call_compute::assert_bitwise_scaled_tensorstest_custom_call_computetest_dense_grad_fp8to allow testing of MXFP8 (currently does not support bias)tests/jax/test_distributed_layernorm_mlp.pywith new test shape to allow for MXFP8 usagexfailto certain configs that fail with the new test case (needs a follow-up investigation)transformer_engine/common/gemm/rocm_gemm.cuIS_NORMtemplate parameter fromcast_mxfp8_2D_kernelscale_invswizzling before GEMM on ROCmscale_invun-padding behavior inNormFwdPrimitiveNormFwdPrimitiveGroupedGemmFFItransformer_engine/jax/layernorm_mlp.pyChecklist: