-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: improve tool execution feedback in non-interactive mode #1383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📋 Review SummaryThis PR improves tool execution feedback in non-interactive mode by adding real-time output display for non-Task tools and showing permission warnings when tools are denied. The changes enhance user experience by providing better visibility into tool execution and clearer guidance on how to enable automatic tool execution. 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
pomelo-nwu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Fixes two issues in non-interactive mode:
Changes
Test Plan
qwen -p 'check npm updates with npm outdate' -yqwen -p 'check npm updates with npm outdate'