fix(cli): persist model selection from /model command to settings.json #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When users select a model via the /model command, the selection was only stored in-memory. After restarting the CLI, the selected model was lost and defaulted back to environment variables or hardcoded settings. This fix adds persistence by calling settings.setValue() to save the selected model to ~/.qwen/settings.json, consistent with how other settings like theme are persisted. Fixes QwenLM#1222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When users select a model via the
/modelcommand, the selection was only stored in-memory. After restarting the CLI, the selected model was lost and defaulted back to environment variables or hardcoded settings.This fix adds persistence by calling
settings.setValue()to save the selected model to~/.qwen/settings.json, consistent with how other settings like theme are persisted.Changes:
SettingsContexttoModelDialogcomponentsettings.setValue(SettingScope.User, 'model.name', model)when a model is selectedTest plan
settings.setValueis called with correct argumentsFixes #1222