Skip to content

Conversation

@ManuelEsparcia
Copy link
Contributor

This PR fixes several small typos in qiskit.passmanager.BasePassManager:

  • Error messages in replace() and remove() now say “does not exist” instead of “does not exists”.
  • The append() and replace() docstrings now refer to “pass manager Task” instead of “passmanager Task”.
  • The run() docstring now uses the grammatically correct phrase
    “The exact arguments passed expose the internals of the pass manager…”.

These changes are purely textual and do not affect runtime behavior.

@ManuelEsparcia ManuelEsparcia requested a review from a team as a code owner November 29, 2025 15:04
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Nov 29, 2025
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Nov 29, 2025

Pull Request Test Coverage Report for Build 19834444145

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 88.395%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/passmanager/passmanager.py 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
crates/circuit/src/parameter/parameter_expression.rs 1 82.3%
crates/qasm2/src/lex.rs 6 91.77%
Totals Coverage Status
Change from base Build 19833347399: 0.01%
Covered Lines: 95744
Relevant Lines: 108314

💛 - Coveralls

@jakelishman
Copy link
Member

Please can you review all of the PRs you've opened, and ensure that each PR contains only the changes it's intended to, and isn't built on top of unrelated PRs.

@ManuelEsparcia ManuelEsparcia force-pushed the fix-basepassmanager-typos branch from 190ebab to fe2252f Compare December 1, 2025 19:12
@ManuelEsparcia
Copy link
Contributor Author

I’ve cleaned up this PR so it only contains the minimal typo fixes in BasePassManager, changing “passmanager Task” to “pass manager Task” in the docstrings and “does not exists” to “does not exist” in the error messages (two occurrences), with no other files or changes included now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community PR PRs from contributors that are not 'members' of the Qiskit repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants