Remove default_scope for reordering records #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a default scope to reorder records is not always the best idea, since it's easy to introduce bugs when using `.first` and `.last` methods. This change fixes an issue when trying to fetch the latest ping for a website, using `.last`, for the retry logic, we were actually fetching the first ping.
|
@bradleyprice, please add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a default scope to reorder records is not always the best
idea, since it's easy to introduce bugs when using
.firstand.lastmethods.This change fixes an issue when trying to fetch the latest ping
for a website, using
.last, for the retry logic, we were actuallyfetching the first ping.