Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 71.03% 71.41% +0.38%
==========================================
Files 9 9
Lines 932 976 +44
==========================================
+ Hits 662 697 +35
- Misses 270 279 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds higher-level registry helpers and Flask API endpoints that return fully aggregated run/sample payloads (including annotations), reducing the number of client-side round trips and aggregation logic.
Changes:
- Added
SampleRegistry.get_full_run()to fetch a run, its samples, and annotations grouped per sample. - Added
SampleRegistry.get_full_sample()to fetch a sample and all annotations. - Added
GET /api/get_full_runandGET /api/get_full_sampleplus API tests validating payload structure/content.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
sample_registry/registrar.py |
Adds registry-layer aggregation helpers for “full run” and “full sample” retrieval. |
sample_registry/app.py |
Adds two new GET endpoints that validate inputs and serialize aggregated results. |
tests/test_api.py |
Adds tests covering both new endpoints and expected annotation payloads. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
SampleRegistry.get_full_run(run_accession)which returns theRunmodel, the list ofSamplemodels for that run, and annotations grouped by sample accession.SampleRegistry.get_full_sample(sample_accession)which returns theSamplemodel and all itsAnnotationrecords.GET /api/get_full_run?run_accession=...andGET /api/get_full_sample?sample_accession=...that perform the same input validation style used elsewhere and serialize results usingapi_model_to_dict.tests/test_api.pyto cover both endpoints and assert payload structure and annotation contents.Testing
pytest -q tests/test_api.pyand all tests passed:14 passed.Codex Task