fix: campaign banner close button styling#677
Open
RisingOrange wants to merge 1 commit intoPauseAI:mainfrom
Open
fix: campaign banner close button styling#677RisingOrange wants to merge 1 commit intoPauseAI:mainfrom
RisingOrange wants to merge 1 commit intoPauseAI:mainfrom
Conversation
Use top:50%/transform:translateY(-50%) instead of top:0/bottom:0 so the button has a fixed size and border-radius:50% produces a circle on hover.
✅ Deploy Preview for pauseai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
RisingOrange
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the campaign banner close button hover effect, which appeared as an oval instead of a circle because the button was stretching to the full banner height.
Summary
top: 0; bottom: 0which stretched it to the full banner heightborder-radius: 50%, this produced an oval hover background instead of a circletop: 50%; transform: translateY(-50%)to give the button a fixed size and proper vertical centeringHow to test
The campaign banner is currently disabled in
+layout.svelte. To reproduce, temporarily restore this version of the condition, and hover over the close button on a multiline banner.Before / After