WIP - PostgreSQL database and Flyway migration #161

P0nk · 2023-02-24T23:43:59Z

Problems:

The database code in Cosmic is all over the place. There's no real separation of concerns which has led to code that is hard to read and hard to maintain.
MySQL is old. PostgreSQL follows the SQL standard more closely and has a lot of advanced features.
The database design is lackluster. There are missing key constraints, inconsistent naming, unused tables & columns and probably more issues.
The initial creation of tables and static data (drops, shop items, etc.) is error prone. It requires manual work and is one of the main issues newcomers struggle with.

Solutions:

Clearly separating database code from the rest with repository classes.
Switch to PostgreSQL
Rewrite the tables from the ground up
Use a database migration tool. Currently that ool is Flyway, but I'm not opposed to switching to Liquibase as it has quite a few useful features.

First step in my plan to switch away from MySQL.

Only makes a difference if there is a large amount of notes in the database. Better be safe than sorry.

This wouldn't be a problem in the first case, if there was a foreign key connection between note and character tables. Can't add that quite yet though.

# Conflicts: # pom.xml

This way you can connect with your favorite db client

These are going to be handy soon, as I'm about to add Caffeine for caching.

MakerProcessor is such a mess...

Preparing for change in Command#handle, which is going to take a CommandContext as an additional argument. This way we can pass in command dependencies in a safe way instead of requiring them to access static methods.

CommandContext is the carrier of dependencies. Currently, it only carries a DropProvider, but it will grow bit by bit as more static singletons and other similar structures get refactored.

The state is not set properly on logout though, so once you log out you can't log back in

Can nog log in, enter game, exit game and re-login successfully.

Works by loading all ip bans on startup and querying the collection in memory rather than making calls on every login.

Works by loading all hwid bans on startup and querying the collection in memory rather than making calls on every login.

Works just like ip and hwid bans in that they are loaded on startup

Almost rid of all db queries in Client

Finally rid of all db code in Client

# Conflicts: # database/sql/1-db_database.sql # docker-compose.yml # pom.xml # scripts/npc/mapleTV.js # src/main/java/net/server/Server.java

P0nk added 30 commits February 24, 2023 21:49

Add Flyway, run db migration in local PostgreSQL db

f119227

First step in my plan to switch away from MySQL.

Add Docker compose support for Postgres

8bb825e

Initiate Postgres connection pool on startup

f6f3c9c

Move notes to the Postgres database

12745c2

Add note receiver index

d018b0f

Only makes a difference if there is a large amount of notes in the database. Better be safe than sorry.

Fix server not able to use note sequence

55e1f65

Fix note not showing if case mismatch in name

b7c7980

This wouldn't be a problem in the first case, if there was a foreign key connection between note and character tables. Can't add that quite yet though.

Add maker_recipe table and data (formerly "makercreatedata")

adbdb89

Add maker_recipe_ingredient table and data (formerly "makerrecipedata")

9819fd5

Add maker_reagent table and data (formerly "makerreagentdata")

26357a8

Add maker_random_reward table and data (formerly "makerrewarddata")

5cecb7a

Get maker reagent from PG db, rework processor (no statics)

c0c0a2d

Merge branch 'master' into feat/postgresql-database

932f9fc

# Conflicts: # pom.xml

Expose containerized databases to host

b329709

This way you can connect with your favorite db client

Cache MakerRecipe, move stimulant to MakerInfoProvider

6073b20

Add tests for MakerInfoProvider

f2ca67a

These are going to be handy soon, as I'm about to add Caffeine for caching.

Cache maker info with Caffeine

9d6574d

Maker disassembly info to MakerInfoProvider

d2d4b44

MakerProcessor is such a mess...

Fix maker disassembly fee not being applied

1fd0963

Get MakerItemCreateEntry from new info provider

0be4856

Add monster_drop table with data

7a848cf

Add DropProvider and dao for monster drops

a70f4e3

Add table, data, and provider method for global drops

5376855

Fix error in monster_drop query

6bf8785

Move "steal item" logic to DropProvider

703ae30

Fix race condition when concurrently Stealing

7ed7b25

Clean up Steal stuff in MIP

a6a7a26

Refactor CommandsExecutor - is no longer static singleton

eed94ec

Preparing for change in Command#handle, which is going to take a CommandContext as an additional argument. This way we can pass in command dependencies in a safe way instead of requiring them to access static methods.

Pass CommandContext to commands

fa3481f

CommandContext is the carrier of dependencies. Currently, it only carries a DropProvider, but it will grow bit by bit as more static singletons and other similar structures get refactored.

Remove "multiple same equip drop" feature

45e2b93

P0nk added 30 commits September 29, 2024 07:52

Log in through AccountService on player login

0bb14e4

Set in transition on log in, now able to enter the game

da4a467

The state is not set properly on logout though, so once you log out you can't log back in

Rename AccountService methods

a580e44

Rename NOT_LOGGED_IN -> LOGGED_OUT

4e1aa1e

Log out in PG on exit game

902f1a1

Can nog log in, enter game, exit game and re-login successfully.

Rename loginattempt

fa666c9

Reduce login state updates, fix multi-login on same acc

5450c29

LoginState enum

b456201

Rename "temp_ban_timestamp" -> "temp_banned_until"

d00b4ed

Show correct ban reason

50524a7

Unify ban handling on login

a307afa

birthday represented as LocalDate

1c6245f

Fix broken test

f142e21

Set ban through AccountService

99006c2

Encapsulate account creation in AccountService

c0ee1f8

Handle ban solely through BanService

e35060d

Clean up tempBanCalendar

988d898

Check banned hwid on login

167937b

Redo ip bans - reduce amount of db queries on login

7661cd0

Works by loading all ip bans on startup and querying the collection in memory rather than making calls on every login.

Redo hwid bans - reduce amount of db queries on login

af02f8b

Works by loading all hwid bans on startup and querying the collection in memory rather than making calls on every login.

Redo mac bans - reduce amount of db queries on login

5d81e05

Works just like ip and hwid bans in that they are loaded on startup

Refactor BanService#ban

e38344c

Save client addresses async on chr select

2b6ef9f

Almost rid of all db queries in Client

Ban ip, macs & hwid in PG

40425ac

Finally rid of all db code in Client

Unban account & ip

64f99a2

Unban macs & hwid

e295a24

Log out everyone on startup

a4f8086

Move chr MySQL saving to CharacterSaver

f2b8ced

Merge branch 'master' into feat/postgresql-database

e4430a3

Merge branch 'master' into feat/postgresql-database

d9d2da1

# Conflicts: # database/sql/1-db_database.sql # docker-compose.yml # pom.xml # scripts/npc/mapleTV.js # src/main/java/net/server/Server.java

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP - PostgreSQL database and Flyway migration #161

WIP - PostgreSQL database and Flyway migration #161

Uh oh!

P0nk commented Feb 24, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

WIP - PostgreSQL database and Flyway migration #161

Are you sure you want to change the base?

WIP - PostgreSQL database and Flyway migration #161

Uh oh!

Conversation

P0nk commented Feb 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

P0nk commented Feb 24, 2023 •

edited

Loading