-
Notifications
You must be signed in to change notification settings - Fork 7
Update germinator deployment for modern Ubuntu #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jimallman
wants to merge
18
commits into
master
Choose a base branch
from
update-for-modern-ubuntu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script has an annoying tendency to fail silently, with no user feedback. I've adapted the logging feature used by other scripts to write a log to ~/log/messages (currently /home/ubuntu/log/messages).
Apparently this was formerly a manual step? Now we make it official, setting the `hostname` and `/etc/hostname` to survive reboots of the deployed server. This is necessary for apache to trust some configuration. Any chance this goes wrong if we have deployed multiple systems to the same server? e.g. `devtree.opentreeoflife.org` and `devapi.opentreeoflife.org`. Comments welcome!
Many of the packages we need for web2py apps (still on python2.*) are no longer provided in modern Ubuntu. Add the necessary repositories to fetch these anyway, alongside their python3 counterparts for our newer code.
Later steps in as-admin.sh would be skipped (w/o warning!) if some of the files we want to backup are missing, which is entirely likely if only some systems are installed.
Apache (rightly) complained about the missing user, but would also have failed with the old paths to /home/opentree/...
Member
Author
|
Hm, it looks like I accidentally picked up an unrelated commit b9a97a5 This should probably be merged, but apologies for the clutter here. |
Stashing this for reference, but it seems to "leak" newer packages and cause trouble. Backing it out next...
This reverts commit 009061e. We'll use a single-file hot fix to venv `activate_this.py` instead
This is just adding the file and README, not yet patching...
mtholder
approved these changes
Aug 29, 2022
Member
mtholder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for now, since we need to deploy old web-apps etc. on new Ubuntu servers.
NB This is a work in progress, so probably best not to merge at this point. But I'm interested in reviews and (esp.) comments where I might have misunderstood the intent of some actions, or failed to consider the consequences of different deployment scenarios. Thanks!