-
Notifications
You must be signed in to change notification settings - Fork 227
conditionally contribute set_error_t(std::exception_ptr) in repeat_* senders
#1799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
justend29
wants to merge
14
commits into
NVIDIA:main
Choose a base branch
from
justend29:repeat-conditional-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+205
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericniebler
requested changes
Jan 28, 2026
Co-authored-by: Eric Niebler <eniebler@boost.org>
Contributor
Author
|
Thank you for the review, @ericniebler. All of your comments have been addressed, though |
Collaborator
|
/ok to test ac8352c |
ericniebler
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
repeat_family of sender adapters invariantly contributesset_error_t(std::exception_ptr)to its completion signatures, which I first mentioned in this issue. This PR causesrepeat_until,repeat, andrepeat_nto conditionally contributeset_error_t(std::exception_ptr)to the completion signatures. Each of the possible cases (not) to contribute the completion signature are individually tested.It also contains some small corrections that were originally in #1797, until @RobertLeahy informed me that it is possible to detect the
noexcept-ness of aconnectusingSTDEXEC::__receiver_archetype<Env>, wherein I returned to this original goal.This is also my first time working with the meta-programming system in this library, so feedback is welcome.