Open
Conversation
edmc-ss
reviewed
Jun 11, 2019
| @@ -1,5 +1,7 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -x | |||
Collaborator
There was a problem hiding this comment.
Still do not prefer this in there to be honest...
edmc-ss
requested changes
Jun 11, 2019
Collaborator
edmc-ss
left a comment
edmc-ss
left a comment
There was a problem hiding this comment.
Just hoping to remove the set -x in start_and_mount_pfs...
I don't want to have to scroll thru a bunch of text to see if things worked as expected...but that's just me...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@edmc-ss I'd be happy to iterate on this with you outside of the critical pfs_middleware fixes!