Extend trackedlock checking to jrpcfs and ramswift.#265
Open
charmster wants to merge 2 commits intodevelopmentfrom
Open
Extend trackedlock checking to jrpcfs and ramswift.#265charmster wants to merge 2 commits intodevelopmentfrom
charmster wants to merge 2 commits intodevelopmentfrom
Conversation
added 2 commits
March 2, 2019 23:08
The jrpcfs package was missed in the original conversion of sync.Mutex --> trackedlock.Mutex. catch it now. ramswift already uses trackedlock, but if it was invoked as a standalone daemon (as jrpcclient tests do), then trackedlocks cannot be enabled from a config file. Fix that. When ramswift is embedded in another test, it was already possible to enable lock tracking for that test.
….log. the jrpcclent unit test, and one other(?), use a stand-alone ramswift process which, thanks to recent changes, now call Up() on the logger which then tries to create the Logfile (if one is specified). unit tests can not/should not try to create /var/log/proxyfs/proxfsd.log, so change the config file used by the unit tests, ramswift/saioramswift0.conf, to override the settins it inherits and specify there is no log file (console output only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jrpcfs package was missed in the original conversion of
sync.Mutex --> trackedlock.Mutex. catch it now.
ramswift already uses trackedlock, but if it was invoked as a
standalone daemon (as jrpcclient tests do), then trackedlocks
cannot be enabled from a config file. Fix that. When ramswift
is embedded in another test, it was already possible to enable
lock tracking for that test.