MDEV-37530 fixes #4503
Open
MDEV-37530 fixes #4503
+87
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadoxV5
force-pushed
the
MDEV-38410
branch
from
6309faa to
1b3ddf0
Compare
|
|
Contributor
Author
|
Yeah PR view doesn’t know that |
ParadoxV5
force-pushed
the
MDEV-38410
branch
from
1b3ddf0 to
7e7df10
Compare
Some environments appear not to retain the backing array of a static `std::initializer_list` in the MDEV-37530 release candidate, and eventually crash when reading overwritten data. This commit resolves the stealth issue by reverting to conventional arrays, while maintaining convenience through deductive overloads.
ParadoxV5
force-pushed
the
MDEV-38410
branch
from
7e7df10 to
33892e7
Compare
ParadoxV5
commented
Dec 31, 2025
sql/rpl_info_file.h
Outdated
Comment on lines
101
to
102
| * my_b_printf() needs updates and so doesn't | ||
| support `long long`s at the movement. |
* Some of our platforms (namely SUSE 15, which uses GCC 7.5) support C++17 syntaxes, but not all libraries, <charconv> among those. * We are yet to figure out what to do with our 10 choices of string→int converters, so now is not the time to settle preferences on <charconv> or whatever superset that covers all of their cases. Co-authored-by: Sergei Golubchik <serg@mariadb.org>
Arithmetics start from `int` and so auto-promotes.
ParadoxV5
force-pushed
the
MDEV-38410
branch
from
33892e7 to
8e24efe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues in MDEV-37530 (#4430) found when releasing v12.3.0 (preview).
Use array, not
std::initializer_listSome environments appear not to retain the backing array of a static
std::initializer_listin the MDEV-37530 release candidate, and eventually crash when reading overwritten data.This commit resolves the stealth issue by reverting to conventional arrays, while maintaining convenience through deductive overloads.
Avoid C++17’s
<charconv>entirely<charconv>among those.<charconv>or whatever superset that covers all of their cases.Warning fix: make
int→ucharexplicitArithmetics start from
intand so auto-promotes.PR quality check
This is a new feature or a refactoring, and the PR is based on themainbranch.