Skip to content

Assignment 01 - Completed#2

Open
Malekikh wants to merge 11 commits intomainfrom
assignment
Open

Assignment 01 - Completed#2
Malekikh wants to merge 11 commits intomainfrom
assignment

Conversation

@Malekikh
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

I noticed that my assignment was pushed to main branch so needed to redo the assignment under the assignment branch.

What did you learn from the changes you have made?

  • How to use log and switch back in time, when you accidently push updates to main branch instead of another branch.
  • use git commands and push/pull to github account

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

followed the commands and didn't consider other options.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

  • Yes, realized that every time I ran my script, the rawdata.zip file was being unzipped again. This was confusing. I confirmed this by looking into (ls) the files that we wanted to delete ipaddr from and ensuring they will not change even though the rawdata file gets unzipped every time I run my script. I confirmed this with chatgpt too.

  • I accidently pushed my updates to main branch. The solution was covered as part of one of the students issue in class and followed that via recordings.

How were these changes tested?

I was using my terminal to ensure changes are made properly. I used bash assignment.sh, but since files/directories already existed at that point, bash assignment.sh was not the best way to check my commands are correct.

A reference to a related issue in your repository (if applicable)

I had some issues with part 2 of assignment. Even though I merge conflict, git add -A, git commit -a, and git push origin assignment, and also git status showing that everything is up to date, I checked my GitHub manually and noticed that the merge conflict is not fixed. I could still see the <>> wording in my script. So I git add assignment.sh and git push, I was worried that if I git push again it goes to my main branch instead of the assignment but it worked.

Checklist

  • I can confirm that my changes are working as intended

@github-actions
Copy link

Autograder results

question status comment
1
2
3
4
5
6 Missing files in data/processed/user_logs
7 One or more files with ipaddr in data/raw not removed.
8 data/inventory.txt does not contain all files in data/processed
9

@github-actions
Copy link

Autograder results

question status comment
1
2
3
4
5
6 Missing files in data/processed/user_logs
7 One or more files with ipaddr in data/raw not removed.
8
9

…data/processed/user_logs 7	❌	One or more files with ipaddr in data/raw not removed. even though there is no ipaddr and user_logs has content inside it
@github-actions
Copy link

Autograder results

question status
1
2
3
4
5
6
7
8
9

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the comments that you have added the pull request. Here are my review comments:

Question 4: Your approach of creating each directory separately works well. There's a another way to achieve the same result using the 'mkdir -p' command. This option automatically creates any missing parent directories in one step. It avoids errors if directories already exist.

Question 8: The >> operator in shell scripting is used for appending output to a file. Please use > to create a new file.

Answer to Question 4 is ok for now. Please change the answer to question 8. Thank you!

@github-actions
Copy link

Autograder results

question status
1
2
3
4
5
6
7
8
9

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants