Open
Conversation
… change was incorrect and rf -rf is not a correct command. It was potentially a mistake. Merge branch 'coworker-changes' of https://github.com/UofT-DSI/shell into assignment
Autograder results
|
Autograder results
|
…data/processed/user_logs 7 ❌ One or more files with ipaddr in data/raw not removed. even though there is no ipaddr and user_logs has content inside it
Autograder results
|
anjali-deshpande-hub
suggested changes
Nov 25, 2024
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
I like the comments that you have added the pull request. Here are my review comments:
Question 4: Your approach of creating each directory separately works well. There's a another way to achieve the same result using the 'mkdir -p' command. This option automatically creates any missing parent directories in one step. It avoids errors if directories already exist.
Question 8: The >> operator in shell scripting is used for appending output to a file. Please use > to create a new file.
Answer to Question 4 is ok for now. Please change the answer to question 8. Thank you!
Autograder results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I noticed that my assignment was pushed to main branch so needed to redo the assignment under the assignment branch.
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
followed the commands and didn't consider other options.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Yes, realized that every time I ran my script, the rawdata.zip file was being unzipped again. This was confusing. I confirmed this by looking into (ls) the files that we wanted to delete ipaddr from and ensuring they will not change even though the rawdata file gets unzipped every time I run my script. I confirmed this with chatgpt too.
I accidently pushed my updates to main branch. The solution was covered as part of one of the students issue in class and followed that via recordings.
How were these changes tested?
I was using my terminal to ensure changes are made properly. I used bash assignment.sh, but since files/directories already existed at that point, bash assignment.sh was not the best way to check my commands are correct.
A reference to a related issue in your repository (if applicable)
I had some issues with part 2 of assignment. Even though I merge conflict, git add -A, git commit -a, and git push origin assignment, and also git status showing that everything is up to date, I checked my GitHub manually and noticed that the merge conflict is not fixed. I could still see the <>> wording in my script. So I git add assignment.sh and git push, I was worried that if I git push again it goes to my main branch instead of the assignment but it worked.
Checklist