Browzine support for journals #333
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 20864415638Details
💛 - Coveralls |
JPrevost
force-pushed
the
use-305-journals
branch
from
002068f to
8f0ba04
Compare
JPrevost
changed the title
No functional changes to Libkey behavior * Renames existing "lookup" route to "libkey" for clarity * Renames LibKey controller to ThirdIronController to allow for upcoming Browzine actions as well https://mitlibraries.atlassian.net/browse/USE-305
Why are these changes being introduced: * Journal records do not have DOI or PMID identifiers, but do have ISSN. Adding Browzine support allows us to provide fulfillment links for journal records via their ISSN. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/USE-305 How does this address that need: * Adds Browzine model to handle API requests * Integrates into views similarly to existing Libkey functionality * Suppresses holdings for Journal records (regardless of if we have Browzine links). Solving holdings will be a future task.
JPrevost
force-pushed
the
use-305-journals
branch
from
8f0ba04 to
6ca38ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commit messages for details.
The code is also likely easier to reason with looking at each commit.
The first commit refactors LibKey integration to more easily add Browzine support.
The second commit adds Browzine support and supresses holdings for all journal records (not just those with Browzine links).
NOTE: the Third Iron APIs (libkey and browzine) share a lot of setup code and we might benefit from refactoring in the future to avoid duplication. However at this time it felt best to just get the functionality in place and look for opportunities to optimize later.
Example searches to see this behavior:
"Journal of Heat Transfer"
"Nature medicine"
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing