fixes missing ApplicationStartup.Path, moved Persister to own Test Pr… #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oject, in anticipation of moving the Persister to its own project
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…-located-on-wsl' of https://github.com/LogExperts/LogExpert into 505-tail-following-stops-working-after-a-while-for-logs-located-on-wsl
Comment on lines
+40
to
+43
| catch | ||
| { | ||
| // Ignore cleanup errors | ||
| } |
Hirogen
deleted the
505-tail-following-stops-working-after-a-while-for-logs-located-on-wsl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the persistence logic in the application to improve file path handling and prepares for moving the persister code to a dedicated assembly. It refactors the
Persisterclass to require the application's startup path when saving and loading session data, ensuring correct directory usage. Additionally, it introduces a new test project for persister functionality and updates the solution file to include it.Persistence logic improvements:
Persisterclass methods (SavePersistenceData,LoadPersistenceData,LoadPersistenceDataOptionsOnly, andBuildPersisterFileName) to require an explicitapplicationStartupPathparameter, ensuring session files are stored in the correct directory. [1] [2] [3] [4] [5]LogWindow.csto passApplication.StartupPathto thePersistermethods, aligning with the new method signatures. [1] [2] [3]BuildSessionFileNameFromPathto use aStringBuilderfor safer string manipulation when generating session file names.Project structure and testing:
LogExpert.Persister.Testswith references and dependencies for unit testing the persister logic.LogExpert.slnto include the new test project and its build configurations. [1] [2] [3]Code organization:
Persisterclass to its own assembly,LogExpert.Persister, for better separation of concerns.…oject, in anticipation of moving the Persister to its own project